From: Artem Bityutskiy <dedekind1@gmail.com>
To: Jamie Iles <jamie@jamieiles.com>
Cc: Scott Wood <scottwood@freescale.com>,
David Woodhouse <dwmw2@infradead.org>,
devicetree-discuss@lists.ozlabs.org,
linux-mtd@lists.infradead.org,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCHv4] mtd: gpio-nand: add device tree bindings
Date: Fri, 19 Aug 2011 22:51:46 +0300 [thread overview]
Message-ID: <1313783508.4475.8.camel@koala> (raw)
In-Reply-To: <20110815152447.GI2636@pulham.picochip.com>
On Mon, 2011-08-15 at 16:24 +0100, Jamie Iles wrote:
> @@ -178,7 +249,7 @@ static int __devexit gpio_nand_remove(struct platform_device *dev)
>
> nand_release(&gpiomtd->mtd_info);
>
> - res = platform_get_resource(dev, IORESOURCE_MEM, 1);
> + res = gpio_nand_get_io_sync(dev);
Why do you call 'gpio_nand_get_io_sync(dev)' here, in
'gpio_nand_remove()' function? You should have it in gpiomtd->io_sync.
Right?
If this is the case, then you do not need a separate
'gpio_nand_get_io_sync()' function at all, you can make
'gpio_nand_get_config()' to fetch the io_sync information from the DT.
And then you will have one single function which gets data from DT, not
2 -> simpler code.
Do I miss something?
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2011-08-19 19:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 15:12 [PATCHv4] mtd: gpio-nand: add device tree bindings Jamie Iles
2011-08-10 15:13 ` Scott Wood
2011-08-11 9:00 ` Jamie Iles
2011-08-15 13:57 ` Artem Bityutskiy
2011-08-15 13:58 ` Jamie Iles
2011-08-15 14:28 ` Artem Bityutskiy
2011-08-15 14:38 ` Jamie Iles
2011-08-15 14:45 ` Artem Bityutskiy
2011-08-15 15:24 ` Jamie Iles
2011-08-19 19:51 ` Artem Bityutskiy [this message]
2011-08-19 21:18 ` Jamie Iles
2011-08-20 3:39 ` Artem Bityutskiy
2011-08-20 6:38 ` Jamie Iles
2011-08-20 12:09 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313783508.4475.8.camel@koala \
--to=dedekind1@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dwmw2@infradead.org \
--cc=grant.likely@secretlab.ca \
--cc=jamie@jamieiles.com \
--cc=linux-mtd@lists.infradead.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox