From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-bw0-f49.google.com ([209.85.214.49]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QudwF-0007XC-2w for linux-mtd@lists.infradead.org; Sat, 20 Aug 2011 05:17:43 +0000 Received: by bke17 with SMTP id 17so3287292bke.36 for ; Fri, 19 Aug 2011 22:17:39 -0700 (PDT) Subject: Re: UBI memory usage on large page nand From: Artem Bityutskiy To: Nicholas Date: Sat, 20 Aug 2011 08:17:36 +0300 In-Reply-To: References: <1301671910.2789.98.camel@localhost> <1302873226.3220.43.camel@localhost> <1302873423.3220.45.camel@localhost> <1303031774.2308.13.camel@koala> <1303115951.2815.35.camel@localhost> <1303284633.2700.3.camel@localhost> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Message-ID: <1313817458.31216.4.camel@koala> Mime-Version: 1.0 Cc: linux-mtd@lists.infradead.org Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2011-08-17 at 14:35 +0800, Nicholas wrote: > Dear Artem, > > 1. drivers/mtd/ubi/build.c > > attach_by_scanning(struct ubi_device *ubi) > > ubi->min_io_size = ubi->mtd->writesize; > ubi->hdrs_min_io_size = ubi->mtd->writesize >> ubi->mtd->subpage_sft; > + ubi->max_write_size = ubi->mtd->writesize; Could you please send a normal kernel patch with a good commit message, e.g., produced with 'git format-patch'. Describe how you tested it as well. There are many internet resources describing how to send good kernel patches. Thanks!