Re: [PATCHv4] mtd: gpio-nand: add device tree bindings

Artem Bityutskiy
2011-08-20T12:09:52Z

On Sat, 2011-08-20 at 07:38 +0100, Jamie Iles wrote:
> Hi Artem,
>
> On Sat, Aug 20, 2011 at 06:39:10AM +0300, Artem Bityutskiy wrote:
> > On Mon, 2011-08-15 at 16:24 +0100, Jamie Iles wrote:
> > > From: Jamie Iles <jamie@jamieiles.com>
> > > Subject: [PATCH] mtd: gpio-nand: add device tree bindings
> > >
> > > Add device tree bindings so that the gpio-nand driver may be
> > > instantiated from the device tree. This also allows the partitions
> > > to be specified in the device tree.
> > >
> > > v5: - fold dt config helpers into a single gpio_nand_of_get_config()
> > > v4: - get io sync address from gpio-control-nand,io-sync-reg
> > > property rather than a resource
> > > - clarified a few details in the binding
> > > v3: - remove redundant cast and a couple of whitespace/naming
> > > changes
> > > v2: - add CONFIG_OF guards for non-dt platforms
> > > - compatible becomes gpio-control-nand
> > > - clarify some binding details
> > >
> > > Cc: David Woodhouse <dwmw2@infradead.org>
> > > Cc: Artem Bityutskiy <dedekind1@gmail.com>
> > > Cc: Scott Wood <scottwood@freescale.com>
> > > Cc: Grant Likely <grant.likely@secretlab.ca>
> > > Signed-off-by: Jamie Iles <jamie@jamieiles.com>
> >
> > Pushed this patch to l2-mtd-2.6.git, thanks.
> >
> > P.S. probably it should contain some reviewed-by tags? I can always add
> > them, though, if needed.
>
> This patch needs of_read_property_u64() from
> http://www.mail-archive.com/devicetree-discuss@lists.ozlabs.org/msg05973.html
> which hasn't been merged yet for the CONFIG_OF case so I'm not sure how this
> should be handled.

Oh, I did not realize that. Well, let's wait when it is include. I'll
drop your patch for now then.