Re: [RFC 3/5] mtd: do not assume oobsize is power of 2

Brian Norris
2011-08-22T20:21:07Z

On Mon, Aug 22, 2011 at 1:46 AM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> On Wed, 2011-08-17 at 16:50 -0700, Brian Norris wrote:
> Once you double checked that you caught all the places which assume
> power-of-2 and do things like "x & (mtd->oobsize - 1", and once you
> confirmed that you did some basic test by running few nandwrite commands
> which involve OOB operations, I think this patch can go in
> independently.

I'll do a little more combing through the code and perform some
independent tests for this patch, then either resend an amended patch
or comment back here.

> IOW, this does need to be RFC, IMO.

I agree. I think I lumped it in with the others because I discovered
it as a byproduct of my work on the other patches in this series.

Brian