From: Artem Bityutskiy <dedekind1@gmail.com>
To: Ricard Wanderlof <ricard.wanderlof@axis.com>
Cc: Brian Norris <computersforpeace@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 3/5] mtd: remove MEMSETOOBSEL macro definition
Date: Wed, 24 Aug 2011 16:19:05 +0300 [thread overview]
Message-ID: <1314191951.9480.277.camel@sauron> (raw)
In-Reply-To: <Pine.LNX.4.64.1108241427380.13510@lnxricardw.se.axis.com>
On Wed, 2011-08-24 at 14:28 +0200, Ricard Wanderlof wrote:
> On Wed, 24 Aug 2011, Brian Norris wrote:
>
> > MEMSETOOBSEL is completely unused and useless. Remove the definition.
> >
> > Note: it's probably best not to use this ioctl number in the future for
> > MTD, since that may cause conflicts between old kernels and new user
> > software (or new kernels and old user software). This shouldn't be much
> > problem.
>
> Perhaps this should be noted as a comment in the code, rather than just
> removing the line. Such information tends to get forgotten sooner or later
> otherwise.
Yeah, I've amended the patch and added a comment:
+/*
+ * Note, the following ioctl existed in the past and was removed:
+ * #define MEMSETOOBSEL _IOW('M', 9, struct nand_oobinfo)
+ * Try to avoid adding a new ioctl with the same ioctl number.
+ */
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2011-08-24 13:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 0:17 [PATCH 1/5] mtd: do not assume oobsize is power of 2 Brian Norris
2011-08-24 0:17 ` [PATCH 2/5] mtd: doc: remove mention of MEMSETOOBSEL Brian Norris
2011-08-24 0:17 ` [PATCH 3/5] mtd: remove MEMSETOOBSEL macro definition Brian Norris
2011-08-24 12:28 ` Ricard Wanderlof
2011-08-24 13:19 ` Artem Bityutskiy [this message]
2011-08-24 0:17 ` [PATCH 4/5] mtd: nand: fix spelling error (date => data) Brian Norris
2011-08-24 0:17 ` [PATCH 5/5] mtd: style fixups in multi-line comment, indentation Brian Norris
2011-08-24 13:10 ` [PATCH 1/5] mtd: do not assume oobsize is power of 2 Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314191951.9480.277.camel@sauron \
--to=dedekind1@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=ricard.wanderlof@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox