From: Artem Bityutskiy <dedekind1@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Ricard Wanderlof <ricard.wanderlof@axis.com>,
Kevin Cernekee <cernekee@gmail.com>,
b35362@freescale.com, Jim Quinlan <jim2101024@gmail.com>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 03/12] mtd: support reading OOB without ECC
Date: Sun, 11 Sep 2011 15:12:44 +0300 [thread overview]
Message-ID: <1315743169.18731.37.camel@sauron> (raw)
In-Reply-To: <1315741622.18731.22.camel@sauron>
On Sun, 2011-09-11 at 14:46 +0300, Artem Bityutskiy wrote:
> On Tue, 2011-08-30 at 18:45 -0700, Brian Norris wrote:
> > -static int mtd_do_readoob(struct mtd_info *mtd, uint64_t start,
> > - uint32_t length, void __user *ptr, uint32_t __user *retp)
> > +static int mtd_do_readoob(struct file *file, struct mtd_info *mtd,
> > + uint64_t start, uint32_t length, void __user *ptr,
> > + uint32_t __user *retp)
> > {
> > + struct mtd_file_info *mfi = file->private_data;
> > struct mtd_oob_ops ops;
> > int ret = 0;
>
> Why do you pass struct file pointer to this function instead of just
> passing the MTD_MODE constant directly? What if the caller does not have
> any 'struct file' at all (e.g., at some point someone would want to make
> an JFFS2 or YAFFS2 optimization and use this function). Do I miss
> something?
>
> If there is not strong reason for passing 'file', could we pass 'int
> mode' instead?
Although after looking a bit closer, I think it is fine, sorry. Pushed
to l2-mtd-2.6.git, thanks!
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2011-09-11 12:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 1:45 [PATCH 00/12] mtd: various "no ECC" and MLC NAND work Brian Norris
2011-08-31 1:45 ` [PATCH 01/12] mtd: nand: initialize chip->oob_poi before write Brian Norris
2011-09-11 11:31 ` Artem Bityutskiy
2011-09-12 9:20 ` THOMSON, Adam (Adam)
2011-08-31 1:45 ` [PATCH 02/12] mtd: support writing OOB without ECC Brian Norris
2011-08-31 1:45 ` [PATCH 03/12] mtd: support reading " Brian Norris
2011-09-11 11:46 ` Artem Bityutskiy
2011-09-11 12:12 ` Artem Bityutskiy [this message]
2011-08-31 1:45 ` [PATCH 04/12] mtd: move mtd_oob_mode_t to shared kernel/user space Brian Norris
2011-09-11 11:57 ` Artem Bityutskiy
2011-09-11 12:28 ` Artem Bityutskiy
2011-09-13 22:29 ` Brian Norris
2011-08-31 1:45 ` [PATCH 05/12] mtd: rename MTD_OOB_* to MTD_OPS_* Brian Norris
2011-09-11 12:10 ` Artem Bityutskiy
2011-09-11 12:29 ` Artem Bityutskiy
2011-08-31 1:45 ` [PATCH 06/12] mtd: rename MTD_MODE_* to MTD_FILE_MODE_* Brian Norris
2011-08-31 1:45 ` [PATCH 07/12] mtd: add MEMWRITE ioctl Brian Norris
2011-09-09 16:59 ` [PATCH v2 " Brian Norris
2011-09-11 12:58 ` Artem Bityutskiy
2011-08-31 1:45 ` [PATCH 08/12] mtd: nand: document nand_chip.oob_poi Brian Norris
2011-09-11 11:58 ` Artem Bityutskiy
2011-08-31 1:45 ` [PATCH 09/12] mtd: document ABI Brian Norris
2011-09-11 12:32 ` Artem Bityutskiy
2011-08-31 1:45 ` [PATCH 10/12] mtd: nand: kill member `ops' of `struct nand_chip' Brian Norris
2011-09-11 12:35 ` Artem Bityutskiy
2011-08-31 1:45 ` [PATCH 11/12] mtd: kill old field for `struct mtd_info_user' Brian Norris
2011-09-11 12:35 ` Artem Bityutskiy
2011-08-31 1:45 ` [PATCH 12/12] mtd: nand: free allocated memory Brian Norris
2011-09-11 12:07 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315743169.18731.37.camel@sauron \
--to=dedekind1@gmail.com \
--cc=b35362@freescale.com \
--cc=cernekee@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jim2101024@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=ricard.wanderlof@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox