From: Artem Bityutskiy <dedekind1@gmail.com>
To: Ricard Wanderlof <ricard.wanderlof@axis.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Anton Olofsson <anol.martinsson@gmail.com>
Subject: Re: mtd-utils: ubiformat: writing images on flash with badblocks.
Date: Mon, 12 Sep 2011 12:33:01 +0300 [thread overview]
Message-ID: <1315819985.18731.72.camel@sauron> (raw)
In-Reply-To: <Pine.LNX.4.64.1109120840020.8150@lnxricardw.se.axis.com>
On Mon, 2011-09-12 at 08:41 +0200, Ricard Wanderlof wrote:
> > On Sun, 11 Sep 2011, Artem Bityutskiy wrote:
> >
> > This issue was reported and analyzed by
> > Anton Olofsson <anol.martinsson@gmail.com>:
> >
> > when ubiformat encounters a write error while flashing the UBI image (which may
> > come from a file of from stdout), it correctly marks the faulty eraseblock as
> > bad and skips it. However, it also incorrectly drops the data buffer which was
> > supposed to be written, and reads next block of data.
>
> I'm just curious, how come this has gone unnoticed for so long? One would
> think that someone would have tried to flash an image to a chip with bad
> blocks a long time ago?
No, bad blocks are handled fine. This is about the situation when an
eraseblock is good, then we write to it, and we get an error, then we
torture it, and the test fails, and we (ubiformat) mark it as bad. This
is very rare situation indeed.
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2011-09-12 9:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 8:26 mtd-utils: ubiformat: writing images on flash with badblocks Anton Olofsson
2011-09-11 10:59 ` Artem Bityutskiy
2011-09-12 6:41 ` Ricard Wanderlof
2011-09-12 9:33 ` Artem Bityutskiy [this message]
2011-09-12 9:40 ` Ricard Wanderlof
2011-09-13 9:33 ` Anton Olofsson
2011-09-19 4:53 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315819985.18731.72.camel@sauron \
--to=dedekind1@gmail.com \
--cc=anol.martinsson@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=ricard.wanderlof@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox