From: Artem Bityutskiy <dedekind1@gmail.com>
To: Bill Pringlemeir <bpringle@sympatico.ca>
Cc: linux-mtd@lists.infradead.org
Subject: Re: RomFS MTD and NAND Flash with ECC (EUCLEAN).
Date: Mon, 19 Sep 2011 08:05:45 +0300 [thread overview]
Message-ID: <1316408751.24366.55.camel@sauron> (raw)
In-Reply-To: <BLU0-SMTP394611D4685CA5AE953006B8060@phx.gbl>
On Fri, 2011-09-16 at 16:46 -0400, Bill Pringlemeir wrote:
> #ifdef CONFIG_ROMFS_ON_MTD
> -#define ROMFS_MTD_READ(sb, ...) ((sb)->s_mtd->read((sb)->s_mtd, ##__VA_ARGS__))
> -
> +#define ROMFS_MTD_READ(sb, ...) \
> + ({ int res; \
> + res = ((sb)->s_mtd->read((sb)->s_mtd, ##__VA_ARGS__)) == -EUCLEAN ? \
> + 0 : res; })
I do not think this is the most elegant way to handle this, but yes,
EUCLEAN is used nowadays to report about bit-flips, which are actually
not an error, more like an info that this eraseblock needs some
attention.
I am not sure MTD is the right subsystem for this patch, could you try
to send it to fs-devel / Al Viro instead?
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2011-09-19 5:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 20:46 RomFS MTD and NAND Flash with ECC (EUCLEAN) Bill Pringlemeir
2011-09-19 5:05 ` Artem Bityutskiy [this message]
2011-09-19 20:19 ` Bill Pringlemeir
2011-09-20 7:41 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316408751.24366.55.camel@sauron \
--to=dedekind1@gmail.com \
--cc=bpringle@sympatico.ca \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox