From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wy0-f177.google.com ([74.125.82.177]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1R5uZp-0008Mw-7N for linux-mtd@lists.infradead.org; Tue, 20 Sep 2011 07:17:09 +0000 Received: by wyh11 with SMTP id 11so233774wyh.36 for ; Tue, 20 Sep 2011 00:17:07 -0700 (PDT) Subject: Re: [PATCH 03/14] mtd: define `is_ecc_error()' macros From: Artem Bityutskiy To: Brian Norris Date: Tue, 20 Sep 2011 10:19:45 +0300 In-Reply-To: References: <1315426421-16243-1-git-send-email-computersforpeace@gmail.com> <1315426421-16243-4-git-send-email-computersforpeace@gmail.com> <1315749440.18731.65.camel@sauron> <1316405649.24366.17.camel@sauron> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Message-ID: <1316503194.4849.39.camel@sauron> Mime-Version: 1.0 Cc: Kevin Cernekee , Matthieu Castet , Jim Quinlan , linux-mtd@lists.infradead.org, David Woodhouse , Matthew Creech Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2011-09-19 at 11:43 -0700, Brian Norris wrote: > Right, I hadn't settled on a name yet and so I haven't rewritten the patches. > > I like the fact that your names are shorter. I'm not sure about > `mtd_is_bitflip_or_eccerr()', though; the compound name seems a little > out of place. But maybe it's just better to be clear on exactly what > is covered by the function. Is there a broad category name for > bitflips/ECC errors? I just consider them corrected/uncorrected errors > in flash, thus the naming I gave. > > I'll either repost with a better naming scheme or update my patches > with the suggested names. OK, let's do this sooner than later please, to make sure I have all your work in my tree, which is safer (consider the situation when dwmw2 picks what I have now and upstreams before we put everything in). -- Best Regards, Artem Bityutskiy