* [PATCH v2] mtd: r852: make r852_pm_ops static
@ 2011-09-26 2:13 Axel Lin
2011-10-01 11:39 ` Bityutskiy, Artem
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2011-09-26 2:13 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-mtd, Artem Bityutskiy, David Woodhouse, Maxim Levitsky
It is not used outside this driver so no need to make the symbol global.
Also make r852_suspend and r852_resume static.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
v2: Also make r852_suspend and r852_resume static
drivers/mtd/nand/r852.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/r852.c b/drivers/mtd/nand/r852.c
index cae2e01..f20f393 100644
--- a/drivers/mtd/nand/r852.c
+++ b/drivers/mtd/nand/r852.c
@@ -1027,7 +1027,7 @@ void r852_shutdown(struct pci_dev *pci_dev)
}
#ifdef CONFIG_PM
-int r852_suspend(struct device *device)
+static int r852_suspend(struct device *device)
{
struct r852_device *dev = pci_get_drvdata(to_pci_dev(device));
@@ -1048,7 +1048,7 @@ int r852_suspend(struct device *device)
return 0;
}
-int r852_resume(struct device *device)
+static int r852_resume(struct device *device)
{
struct r852_device *dev = pci_get_drvdata(to_pci_dev(device));
@@ -1092,7 +1092,7 @@ static const struct pci_device_id r852_pci_id_tbl[] = {
MODULE_DEVICE_TABLE(pci, r852_pci_id_tbl);
-SIMPLE_DEV_PM_OPS(r852_pm_ops, r852_suspend, r852_resume);
+static SIMPLE_DEV_PM_OPS(r852_pm_ops, r852_suspend, r852_resume);
static struct pci_driver r852_pci_driver = {
.name = DRV_NAME,
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] mtd: r852: make r852_pm_ops static
2011-09-26 2:13 [PATCH v2] mtd: r852: make r852_pm_ops static Axel Lin
@ 2011-10-01 11:39 ` Bityutskiy, Artem
0 siblings, 0 replies; 2+ messages in thread
From: Bityutskiy, Artem @ 2011-10-01 11:39 UTC (permalink / raw)
To: Axel Lin
Cc: David Woodhouse, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, Maxim Levitsky
On Mon, 2011-09-26 at 10:13 +0800, Axel Lin wrote:
> It is not used outside this driver so no need to make the symbol global.
> Also make r852_suspend and r852_resume static.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> v2: Also make r852_suspend and r852_resume static
Pushed to l2-mtd-2.6.git, thanks!
--
Best Regards,
Artem Bityutskiy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-01 11:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-26 2:13 [PATCH v2] mtd: r852: make r852_pm_ops static Axel Lin
2011-10-01 11:39 ` Bityutskiy, Artem
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).