From: Artem Bityutskiy <dedekind1@gmail.com>
To: Andres Salomon <dilinger@queued.net>
Cc: linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] jffs2: allow disabling of compression schemes at runtime
Date: Fri, 14 Oct 2011 11:50:37 +0300 [thread overview]
Message-ID: <1318582244.12351.73.camel@sauron> (raw)
In-Reply-To: <20111003191624.7efd3dce@queued.net>
On Mon, 2011-10-03 at 19:16 -0700, Andres Salomon wrote:
> Currently jffs2 has compile-time constants (and .config options)
> regarding whether or not the various compression/decompression
> drivers are built in and enabled. This is fine for embedded
> systems, but it clashes with distribution kernels. Distro kernels
> tend to turn on everything; this causes OpenFirmware to fall
> over, as it only supports ZLIB decompression. Booting a kernel
> that has LZO compression enabled, writing to the boot partition,
> and then rebooting causes OFW to fail to read the kernel from
> the filesystem. This is because LZO compression has priority
> when writing new data to jffs2, if LZO is enabled.
>
> To get around that, this patch adds jffs2 module params for each
> compressor type that isn't decompression-only. That means I can run
> a kernel that has support for LZO and ZLIB decompression (allowing
> me to read LZO data off of the root partition), while disabling
> LZO compression writes (jffs2.disable_lzo=1) so that the boot
> partition stays compatible with OFW.
>
> Signed-off-by: Andres Salomon <dilinger@queued.net>
You should use mount options instead. Invent nice mount options to
configure compression strategy of JFFS2.
Or you can simply implement the same option as UBIFS has: compr=xxx.
See Documentation/filesystems/ubifs.txt
With this option you set the default compressor which is use when
writing, and on reading all decompression are supported, seems like
exactly what you want. You can also look how it is implemented in UBIFS
for reference.
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2011-10-14 8:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 2:16 [PATCH] jffs2: allow disabling of compression schemes at runtime Andres Salomon
2011-10-14 8:50 ` Artem Bityutskiy [this message]
2011-10-14 14:14 ` Andres Salomon
2011-10-14 14:22 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318582244.12351.73.camel@sauron \
--to=dedekind1@gmail.com \
--cc=dilinger@queued.net \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox