From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com ([192.55.52.88]) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1RFQqu-0001H6-1T for linux-mtd@lists.infradead.org; Sun, 16 Oct 2011 13:34:09 +0000 From: "Bityutskiy, Artem" To: "snijsure@grid-net.com" Subject: Re: [PATCH resend v2] Add security.selinux XATTR support for the UBIFS. Also fix couple of bugs in UBIFS extended attribute storage Date: Sun, 16 Oct 2011 13:34:00 +0000 Message-ID: <1318772023.7278.0.camel@sauron> References: <1318629018.26165.37.camel@subodh-desktop> In-Reply-To: <1318629018.26165.37.camel@subodh-desktop> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Content-Transfer-Encoding: base64 Cc: mtd , "Hunter, Adrian" Reply-To: "Bityutskiy, Artem" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , R29vZCBqb2IgaW4gZ2VuZXJhbCwgdGhhbmtzIGEgbG90LiBCdXQgSSB0aGluayB5b3UgbmVlZCB0 byB3b3JrIG9uIHRoaXMNCnBhdGNoIHNvbWUgbW9yZS4NCg0KSSByZW1lbWJlciBsb25nIHRpbWUg YWdvIHlvdSBzYWlkIHlvdSBmb3VuZCBhIGJ1ZyBpbiBVQklGUyB4YXR0cg0KaGFuZGxpbmcgLSBj b3VsZCB5b3UgcGxlYXNlIHN1Ym1pdCBpdCBhcyBhIHNlcGFyYXRlIHBhdGNoPw0KDQpGaXJzdCwg ZmV3IG5pdHBpY2tzOg0KDQpPbiBGcmksIDIwMTEtMTAtMTQgYXQgMTQ6NTAgLTA3MDAsIFN1Ym9k aCBOaWpzdXJlIHdyb3RlOg0KPiBPbmx5IGNoYW5nZSBzaW5jZSB0aGUgcHJldmlvdXMgcGF0Y2gg aXMgc291cmNlIGNvZGUgZm9ybWF0IGNoYW5nZXMuDQoNCjEuIFdoeSB5b3UgcmVtb3ZlZCB0aGUg dGV4dCBhYm91dCBob3cgeW91IHRlc3RlZCB0aGlzIHdpdGggc2VsaW51eD8NCiAgIFRoYXQgdGV4 dCB3YXMgaW5jbHVkZWQgd2hlbiB5b3Ugc3VibWl0dGVkIHRoZSBwYXRjaCBmaXJzdCB0aW1lLg0K Mi4gQnV0IHBsZWFzZSwgZG8gbm90IHB1dCB0aGF0IGJpZyBzaGVsbCBzY3JpcHRzIHRvIGNvbW1p dCBtZXNzYWdlIDotKQ0KMy4gUGxlYXNlLCBjbGVhbi11cCB0aGUgc3ViamVjdCAtIGl0IHNob3Vs ZCBiZSBzaG9ydGVyLg0KNC4gUGxlYXNlLCBhZGQgIlVCSUZTOiIgcHJlZml4IHRvIHRoZSBzdWJq ZWN0Lg0KDQoNCj4gbWtkaXIgLXAgL3RtcC9mbGFzaDANCj4gbW91bnQgLXQgdWJpZnMgdWJpMDpy b290LTAgL3RtcC9mbGFzaDANCj4gaW50ZWdjayAtcCAvdG1wL2ZsYXNoMC8NCg0KNS4gUGxlYXNl LCByZW1vdmUgdGhpcyBzY3JpcHQsIGl0IGlzIGVub3VnaCB0byBzYXkgdGhhdCBpbnRlZ2NrIHdh cw0KICAgaGFwcHkuDQoNCjYuIFRoYW5rcyBmb3IgYWxpZ25pbmcgdGhlIHN0eWxlIHdpdGggdGhl IG9yaWdpbmFsIFVCSUZTIHN0eWxlLiBIb3dldmVyLA0KICAgdGhpcyBpcyBub3QgZXhhY3RseSBp dC4gWW91IHNob3VsZCB5b3UgdGFicyBmb3IgaW5kZW50cywgYW5kIGF0IHRoZQ0KICAgZW5kIHVz ZSBmZXcgc3BhY2VzIHRvIGZpbmUtdHVuZSB0aGUgYWxpZ25tZW50LiBZb3Ugc2hvdWxkIG5ldmVy IHB1dA0KICAgbW9yZSB0aGFuIDcgc3BhY2VzLCBiZWNhdXNlIDggc3BhY2VzIGlzIGFscmVhZHkg b25lIHRhYi4NCg0KICAgT3IgdG8gcHV0IGl0IGRpZmZlcmVudGx5LCBydW4gY2hlY2twYXRjaC5w bCBhbmQgeW91IHdpbGwgc2VlIGVycm9yIC0NCiAgIHBsZWFzZSwgZml4IHRoZW0uDQoNCj4gZGlm ZiAtLWdpdCBhL2ZzL3ViaWZzL2Rpci5jIGIvZnMvdWJpZnMvZGlyLmMNCj4gaW5kZXggNjgzNDky MC4uYjc0NGNkOCAxMDA2NDQNCj4gLS0tIGEvZnMvdWJpZnMvZGlyLmMNCj4gKysrIGIvZnMvdWJp ZnMvZGlyLmMNCj4gQEAgLTI1Myw2ICsyNTMsNTIgQEAgb3V0Og0KPiAgCXJldHVybiBFUlJfUFRS KGVycik7DQo+ICB9DQo+ICANCj4gK3N0YXRpYyB2b2lkIHViaWZzX2luaXRfc2VjdXJpdHkoc3Ry dWN0IGRlbnRyeSAqZGVudHJ5LCBzdHJ1Y3QgaW5vZGUNCj4gKmlub2RlLA0KPiArCQkJCXN0cnVj dCBpbm9kZSAqZGlyKQ0KDQpDb3VsZCB5b3UgcGxlYXNlIHNlbmQgYSBwYXRjaCB3aGljaCBpcyBu b3QgbGluZS13cmFwcGVkPyBUcnkgJ2dpdA0Kc2VuZC1tYWlsJy4gVHJ5IHRvIHNhdmUgdGhpcyBw YXRjaCBhbmQgYXBwbHkgaXQgLSB5b3Ugd2lsbCBzZWUgd2h5IEkNCmNvbXBsYWluOiBpdCB3b24n dCBhcHBseS4gSW4gZ2VuZXJhbCwgeW91IHNob3VsZCBzZW5kIHBhdGNoZXMgd2hpY2gNCm90aGVy cyBjYW4gc2F2ZSBhbmQganVzdCBhcHBseSB3aXRoICdnaXQgYW0nLg0KDQo+ICt7DQo+ICsJaW50 IGVycjsNCj4gKwljaGFyICpuYW1lOw0KPiArCXZvaWQgKnZhbHVlID0gTlVMTDsNCj4gKwlzaXpl X3QgbGVuID0gMDsNCj4gKwlzdHJ1Y3QgdWJpZnNfaW5vZGUgKmRpcl91aSA9IHViaWZzX2lub2Rl KGRpcik7DQo+ICsJY29uc3Qgc3RydWN0IHFzdHIgKnFuYW1lID0gJmRlbnRyeS0+ZF9uYW1lOw0K PiArDQo+ICsJbXV0ZXhfbG9jaygmZGlyX3VpLT51aV9tdXRleCk7DQo+ICsJbXV0ZXhfbG9jaygm ZGVudHJ5LT5kX2lub2RlLT5pX211dGV4KTsNCj4gKwllcnIgPSBzZWN1cml0eV9pbm9kZV9pbml0 X3NlY3VyaXR5KGlub2RlLCBkaXIsIHFuYW1lLCAmbmFtZSwgJnZhbHVlLA0KPiArCQkmbGVuKTsN Cg0KUGxlYXNlLCBhbGlnbiBsZW4gdG8gdGhlICJpbm9kZSIgdXNpbmcgZmlyc3QgdGFicyB0aGVu IGZldyBzcGFjZXMsIHRvIGJlIG9mDQp0aGUgc2FtZSBzdHlsZSBhcyB0aGUgcmVzdCBvZiB0aGUg Y29kZS4NCg0KPiArCWlmIChlcnIpIHsNCj4gKwkJaWYgKGVyciA9PSAtRU9QTk9UU1VQUCkNCj4g Kw0KCQkJcmV0dXJuOw0KSSBiZWxpZXZlIHlvdSBtZWFudDoNCg0KaWYgKGVyciA9PSAtRU9QTk9U U1VQUCkNCgl1Ymlmc19lcnIoInVuYWJsZSB0byByZXRyaWV2ZSBzZWN1cml0eSBjb250ZXh0LCBl cnJvciAlZCIsIGVycik7DQoNCk9yIHlvdSByZWFsbHkgbWVhbnQgdG8gcmV0dXJuIHdpdGhvdXQg dW5sb2NraW5nIHRoZSBtdXRleGVzPw0KDQo+ICsJCXViaWZzX2VycigidW5hYmxlIHRvIHJldHJp ZXZlIHNlY3VyaXR5IGNvbnRleHQsIGVycm9yICVkIiwgZXJyKTsNCj4gKwkJbXV0ZXhfdW5sb2Nr KCZkZW50cnktPmRfaW5vZGUtPmlfbXV0ZXgpOw0KPiArCQltdXRleF91bmxvY2soJmRpcl91aS0+ dWlfbXV0ZXgpOw0KPiArCQlyZXR1cm47DQoNClJlbW92ZSAzIGFib3ZlIGxpbmVzIGFuZCBwdXQ6 DQoNCgkJZ290byBvdXRfdW5sb2NrOw0KDQppbnN0ZWFkLg0KDQo+ICsJfQ0KPiArDQo+ICsJaWYg KHN0cm5jbXAobmFtZSwgInNlbGludXgiLCBzdHJsZW4oInNlbGludXgiKSkgPT0gMCkgew0KPiAr CQlrZnJlZShuYW1lKTsNCj4gKwkJbmFtZSA9IGtzdHJkdXAoInNlY3VyaXR5LnNlbGludXgiLCBH RlBfTk9GUyk7DQoNClNvcnJ5LCBubywgeW91IHNob3VsZCBub3QgcmUtYWxsb2NhdGUgdGhpcywg dGhpcyBpcyBub3QgYSBjbGVhbiBhcHByb2FjaC4NClBsZWFzZSwgdGFrZSBhIGxvb2sgYXQgZXh0 NCBhbmQgdHJ5IHRvIG1vZGVsIGFmdGVyIHRoZWlyIGNvZGUuIFdlbGwsDQp0aGV5IHByb2JhYmx5 IGRvIG1vcmUgdGhhbiB5b3UgbmVlZCwgc28gZG8gbm90IGNvcHkgZXZlcnl0aGluZyBibGluZGx5 DQpvZiBjb3Vyc2UuDQoNCkluIHRoZW9yeSwgdGhpcyBjb2RlIHNob3VsZCBiZSB0aGUgc2FtZSBm b3IgYW55IExTTSAtIHdoZXRoZXIgaXQgaXMNCnNlbGludXggb3Igc21hY2suIFlvdSByZWFsbHkg c2hvdWxkIG5vdCBoYXZlICdzdHJjbXAobmFtZSwgInNlbGludXgiKScNCnRoaW5ncy4NCg0KQWxz bywgSSBzdHJvbmdseSBzdXNwZWN0IHRoYXQgZXh0NCBkb2VzIG5vdCBzdG9yZSB0aGUgJ3NlY3Vy aXR5LicgcGFydA0Kb24gdGhlIG1lZGlhIC0gYnV0IEkgZGlkIG5vdCBjaGVjayB0aGlzIGZvciBz dXJlIGFuZCBsZWF2ZSB0aGlzIGFjdGl2aXR5DQp0byB5b3UgOi0pIElmIGl0IGRvZXMgbm90LCB3 ZSBhbHNvIHNob3VsZCBub3QgZG8gdGhpcy4NCg0KPiArCQlpZiAoIW5hbWUpIHsNCj4gKwkJCXVi aWZzX2VycigidW5hYmxlIHRvIHNldCBzZWN1cml0eSBjb250ZXh0ICUuKnMgZXJyb3IiLA0KPiAr CQkJCSAgZGVudHJ5LT5kX25hbWUubGVuLCBkZW50cnktPmRfbmFtZS5uYW1lKTsNCj4gKwkJCWtm cmVlKHZhbHVlKTsNCj4gKwkJCW11dGV4X3VubG9jaygmZGVudHJ5LT5kX2lub2RlLT5pX211dGV4 KTsNCj4gKwkJCW11dGV4X3VubG9jaygmZGlyX3VpLT51aV9tdXRleCk7DQo+ICsJCQlyZXR1cm47 DQo+ICsJCX0NCj4gKwl9DQoNClNvLCB0YWtpbmcgaW50byBhY2NvdW50IHdoYXQgSSBzYWlkIGFi b3ZlLCBJIHRoaW5rIHdob2xlIHRoaXMgYmxvY2sgc2hvdWxkDQpkaWUuDQoNCldlbGwsIEkgcGVy c29uYWxseSBkbyBub3QgaGF2ZSBvYmplY3Rpb25zIGlmIHlvdSBkbyBub3QgdGVzdCBzbWFjay4N Ck9mIGNvdXJzZSBpdCB3b3VsZCBiZSBncmVhdCBpZiB5b3UgZGlkLCBidXQgSSBhbSBmaW5lIGlm IHlvdSBwdXQNCnNvbWV0aGluZyBsaWtlIHRoaXMgaGVyZSBhbmQgbGVhdmUgdGhlIHNtYWNrIGV4 ZXJjaXNlIGZvciBzb21lb25lDQp3aG8gdXNlcyBpdDoNCg0KLyogV2UgdGVzdGVkIG9ubHkgU0Vs aW51eCwgc29ycnkgKi8NCmlmIChzdHJjbXAobmFtZSwgWEFUVFJfU0VMSU5VWF9TVUZGSVgpDQoJ Z290byBvdXRfZnJlZTsNCg0KDQo+ICsJZXJyID0gdWJpZnNfc2V0eGF0dHIoZGVudHJ5LCBuYW1l LCB2YWx1ZSwgbGVuLCAwKTsNCj4gKwlpZiAoZXJyKQ0KPiArCQl1Ymlmc19lcnIoInVuYWJsZSB0 byBzZXQgc2VjdXJpdHkgY29udGV4dCBuYW1lICUuKnMgZXJyb3IgJWQiLA0KPiArCQkJICBkZW50 cnktPmRfbmFtZS5sZW4sIGRlbnRyeS0+ZF9uYW1lLm5hbWUsIGVycik7DQoNClNvLCBwcm9iYWJs eSB5b3UgbmVlZCB0byBwYXNzIHRoZSBYQVRUUl9TRUNVUklUWV9QUkVGSVggaW50byB0aGlzIGZ1 bmN0aW9uDQphbmQgbGV0IGl0IGRlYWwgd2l0aCB0aGUgbmFtZS4gUHJvYmFibHkgeW91IGNhbiBh ZGQgb25lIG1vcmUgcGFyYW1ldGVyIHRvDQp0aGlzIGZ1bmN0aW9uLCBzYXksICJwcmVmaXgiLiAg Rm9yIG5vbi1zZWN1cml0eSBjYXNlcyBpdCB3b3VsZCBiZSBOVUxMLA0Kb3RoZXJ3aXNlIC0gWEFU VFJfU0VDVVJJVFlfUFJFRklYLg0KDQpQbGVhc2UsIG1ha2UgdGhhdCB0byBiZSBhIF9zZXBhcmF0 ZV8gcGF0Y2guDQoNCj4gKwlrZnJlZShuYW1lKTsNCm91dF9mcmVlOg0KPiArCWtmcmVlKHZhbHVl KTsNCm91dF91bmxvY2s6DQo+ICsJbXV0ZXhfdW5sb2NrKCZkZW50cnktPmRfaW5vZGUtPmlfbXV0 ZXgpOw0KPiArCW11dGV4X3VubG9jaygmZGlyX3VpLT51aV9tdXRleCk7DQo+ICt9DQoNCg0KLS0g DQpCZXN0IFJlZ2FyZHMsDQpBcnRlbSBCaXR5dXRza2l5DQoNCg0KLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCkludGVs IEZpbmxhbmQgT3kKUmVnaXN0ZXJlZCBBZGRyZXNzOiBQTCAyODEsIDAwMTgxIEhlbHNpbmtpIApC dXNpbmVzcyBJZGVudGl0eSBDb2RlOiAwMzU3NjA2IC0gNCAKRG9taWNpbGVkIGluIEhlbHNpbmtp IAoKVGhpcyBlLW1haWwgYW5kIGFueSBhdHRhY2htZW50cyBtYXkgY29udGFpbiBjb25maWRlbnRp YWwgbWF0ZXJpYWwgZm9yCnRoZSBzb2xlIHVzZSBvZiB0aGUgaW50ZW5kZWQgcmVjaXBpZW50KHMp LiBBbnkgcmV2aWV3IG9yIGRpc3RyaWJ1dGlvbgpieSBvdGhlcnMgaXMgc3RyaWN0bHkgcHJvaGli aXRlZC4gSWYgeW91IGFyZSBub3QgdGhlIGludGVuZGVkCnJlY2lwaWVudCwgcGxlYXNlIGNvbnRh Y3QgdGhlIHNlbmRlciBhbmQgZGVsZXRlIGFsbCBjb3BpZXMuCg==