From: David Woodhouse <dwmw2@infradead.org>
To: andersen@codepoet.org
Cc: linux-mtd@lists.infradead.org
Subject: Re: mkfs.jffs2.c rework
Date: Mon, 25 Nov 2002 11:49:05 +0000 [thread overview]
Message-ID: <1319.1038224945@passion.cambridge.redhat.com> (raw)
In-Reply-To: <20021125111843.GA17562@codepoet.org>
> /* The kernel assumes PAGE_CACHE_SIZE as block size. */
> #if defined(__ia64__)
> # define PAGE_CACHE_SIZE (16384)
> #else
> # define PAGE_CACHE_SIZE (4096)
> #endif
Er, so if you're cross-building your file system on an IA64, it gets a page
size of 16KiB by default? No likee :)
Anyway, page size isn't even always 16KiB on IA64 either, is it? Stick to
4KiB default -- it's safer. If you know the target system has a larger page
size, you can specify it on the command line. Same logic as keeping the
erase size small by default.
How about changing cpu_to_target32() et al. to be cpu_to_je32() to match the
JFFS2 code?
Also, could we have an option to write cleanmarkers to the beginning of
each block?
--
dwmw2
next prev parent reply other threads:[~2002-11-25 11:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-25 11:18 mkfs.jffs2.c rework Erik Andersen
2002-11-25 11:49 ` David Woodhouse [this message]
2002-11-25 12:06 ` Erik Andersen
2002-11-25 12:12 ` David Woodhouse
2002-11-25 12:21 ` Erik Andersen
2002-11-25 12:39 ` Kenneth Johansson
2002-11-25 13:50 ` johan.adolfsson
2002-11-25 16:18 ` Joakim Tjernlund
2002-11-25 16:20 ` David Woodhouse
2002-11-25 16:33 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319.1038224945@passion.cambridge.redhat.com \
--to=dwmw2@infradead.org \
--cc=andersen@codepoet.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox