From: Artem Bityutskiy <dedekind1@gmail.com>
To: Wolfram Sang <w.sang@pengutronix.de>, Roland Kletzing <devzero@web.de>
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
adrian.hunter@intel.com, Willy Tarreau <w@1wt.eu>
Subject: Re: [BUG] Re: mtd_stresstest module bricked my dockstar
Date: Tue, 25 Oct 2011 00:04:15 +0300 [thread overview]
Message-ID: <1319490276.12314.9.camel@golum> (raw)
In-Reply-To: <20111024195313.GA6326@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 909 bytes --]
> > Anyway - what would people think if linux had a kernel module which wipes
> > /dev/sda1 when loaded ? :)
Yeah, the tests are destructive and they start erasing and torturing
your MTD device without preserving your data.
And the bad thing is - if you do not pass any parameter, they will
torture your mtd0.
I am sorry that you bricked your device and I hope you will be able to
resurrect it. This was an oversight. The tests were written for
validating new drivers and making sure they are robust. So we always
assumed people run them on a development HW, not on a production HW.
That was a false implicit assumption.
Yes, we should use -1 as the default value, and print a scary warning
message when the module is inserted without a parameter. We should
probably also put word "destructive" or something like this to the
module description.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-10-24 21:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <69501156.1798237.1319395066798.JavaMail.fmail@mwmweb003>
[not found] ` <20111024055705.GA4020@1wt.eu>
[not found] ` <B10F15EA8AB74E698DC0D94563A30BE7@samsungnetbook>
2011-10-24 19:53 ` [BUG] Re: mtd_stresstest module bricked my dockstar Wolfram Sang
2011-10-24 21:04 ` Artem Bityutskiy [this message]
2011-10-24 21:24 ` Wolfram Sang
2011-10-24 22:16 ` Artem Bityutskiy
2011-10-24 21:31 Roland Kletzing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319490276.12314.9.camel@golum \
--to=dedekind1@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=devzero@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=w.sang@pengutronix.de \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).