Re: [PATCH 2/2] mtd: mark tests EXPERIMENTAL

Artem Bityutskiy
2011-10-29T20:30:11Z

On Tue, 2011-10-25 at 11:09 +0200, Wolfram Sang wrote:
> The tests may erase mtd devices, so mark them EXPERIMENTAL and emphasize
> this fact in the Kconfig entry, so users will think twice before running
> them.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
> drivers/mtd/Kconfig | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
> index 4be8373..81d9b92 100644
> --- a/drivers/mtd/Kconfig
> +++ b/drivers/mtd/Kconfig
> @@ -27,12 +27,15 @@ config MTD_DEBUG_VERBOSE
>
> config MTD_TESTS
> tristate "MTD tests support"
> - depends on m
> + depends on m && EXPERIMENTAL
> help
> This option includes various MTD tests into compilation. The tests
> should normally be compiled as kernel modules. The modules perform
> various checks and verifications when loaded.
>
> + WARNING: Some of the tests will ERASE THE CONTENT of mtd devices!
> + Do not use these tests unless you are sure you really need to.
> +

I am OK with this close, but I am not sure about the EXPERIMENTAL. I
though this is used for the code which is considered to be "not ready"
for real use, while the tests work well.

Artem.