Re: [PATCH 2/2] mtd: mark tests EXPERIMENTAL

Artem Bityutskiy
2011-10-30T12:29:56Z

On Sat, 2011-10-29 at 22:40 +0200, Wolfram Sang wrote:
> > > diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
> > > index 4be8373..81d9b92 100644
> > > --- a/drivers/mtd/Kconfig
> > > +++ b/drivers/mtd/Kconfig
> > > @@ -27,12 +27,15 @@ config MTD_DEBUG_VERBOSE
> > >
> > > config MTD_TESTS
> > > tristate "MTD tests support"
> > > - depends on m
> > > + depends on m && EXPERIMENTAL
> >
> > I am OK with this close, but I am not sure about the EXPERIMENTAL. I
> > though this is used for the code which is considered to be "not ready"
> > for real use, while the tests work well.
>
> Well, yeah, it is not perfect, but the closest I could come up with
> (EXPERT is a lot worse). My reasoning went a bit in the direction of
> "you usually need the tests for experimental drivers".

I see, but I think that this is not what EXPERIMENTAL mean. It is better
to add "(DANGEROUS)" to the title as it is recommended in
Documentation/CodyngStyle.

Artem.