Re: [PATCH 1/2] Integrated Flash Controller support

[Artem Bityutskiy <dedekind1@gmail.com>]

Probably some PPC mailing list should be CCed? Could you please CC at
least LKML?

On Fri, 2011-10-28 at 13:40 +0800, b35362@freescale.com wrote:
> +config FSL_IFC
> +        bool "Freescale Integrated Flash Controller support"
> +        depends on FSL_SOC
> +        help
> +          Enables reporting of errors from the Freescale integrated
> +          flash controller.  Also contains some common code used by
> +          drivers for specific ifc controller peripherals.

Why this cannot be a module?


> +/*
> + * IFC Controller NAND Machine registers
> + */
> +struct fsl_ifc_nand {
> +	__be32 ncfgr;
> +	u32 res1[0x4];
> +	__be32 nand_fcr0;
> +	__be32 nand_fcr1;
> +	u32 res2[0x8];
> +	__be32 row0;
> +	u32 res3;
> +	__be32 col0;
> +	u32 res4;
> +	__be32 row1;
> +	u32 res5;
> +	__be32 col1;
> +	u32 res6;
> +	__be32 row2;
> +	u32 res7;
> +	__be32 col2;
> +	u32 res8;
> +	__be32 row3;
> +	u32 res9;
> +	__be32 col3;
> +	u32 res10[0x24];

I do not know the HW, but I wonder why some fields are __be32 and some
are u32? What is the logic behind that?