* [Regression PATCH] pxa2xx-flash.c: Not falling back to partition table as it previously did.
@ 2011-11-11 17:06 Jonathan Cameron
2011-11-11 17:06 ` [PATCH] mtd: pxa2xx-flash.c: It used to fall back to provided table Jonathan Cameron
0 siblings, 1 reply; 5+ messages in thread
From: Jonathan Cameron @ 2011-11-11 17:06 UTC (permalink / raw)
To: linux-mtd; +Cc: dbaryshkov, Artem.Bityutskiy, dwmw2, Jonathan Cameron
mtd: pxa2xx-flash.c: use mtd_device_parse_register
changed the behaviour, at least for stargate2.
Previously it used the contents of flash->partitions
to init the partitions. Now those are ignored.
The following is a trivial fix. I have no idea if
this is the right fix though.
If I've missed a patch fixing this, sorry for the noise.
Jonathan
Jonathan Cameron (1):
mtd: pxa2xx-flash.c: It used to fall back to provided table.
drivers/mtd/maps/pxa2xx-flash.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
1.7.7.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] mtd: pxa2xx-flash.c: It used to fall back to provided table.
2011-11-11 17:06 [Regression PATCH] pxa2xx-flash.c: Not falling back to partition table as it previously did Jonathan Cameron
@ 2011-11-11 17:06 ` Jonathan Cameron
2011-11-11 22:40 ` Dmitry Eremin-Solenikov
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jonathan Cameron @ 2011-11-11 17:06 UTC (permalink / raw)
To: linux-mtd; +Cc: dbaryshkov, Artem.Bityutskiy, dwmw2, Jonathan Cameron
From: Jonathan Cameron <jic23@cam.ac.uk>
Make this work again.
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
---
drivers/mtd/maps/pxa2xx-flash.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/maps/pxa2xx-flash.c b/drivers/mtd/maps/pxa2xx-flash.c
index 411a17d..2a25b67 100644
--- a/drivers/mtd/maps/pxa2xx-flash.c
+++ b/drivers/mtd/maps/pxa2xx-flash.c
@@ -98,7 +98,7 @@ static int __devinit pxa2xx_flash_probe(struct platform_device *pdev)
}
info->mtd->owner = THIS_MODULE;
- mtd_device_parse_register(info->mtd, probes, 0, NULL, 0);
+ mtd_device_parse_register(info->mtd, probes, 0, flash->parts, flash->nr_parts);
platform_set_drvdata(pdev, info);
return 0;
--
1.7.7.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] mtd: pxa2xx-flash.c: It used to fall back to provided table.
2011-11-11 17:06 ` [PATCH] mtd: pxa2xx-flash.c: It used to fall back to provided table Jonathan Cameron
@ 2011-11-11 22:40 ` Dmitry Eremin-Solenikov
2011-11-17 21:54 ` Artem Bityutskiy
2011-12-06 21:06 ` Artem Bityutskiy
2 siblings, 0 replies; 5+ messages in thread
From: Dmitry Eremin-Solenikov @ 2011-11-11 22:40 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: Artem.Bityutskiy, linux-mtd, dwmw2, Jonathan Cameron
On Fri, Nov 11, 2011 at 9:06 PM, Jonathan Cameron <jic23@kernel.org> wrote:
> From: Jonathan Cameron <jic23@cam.ac.uk>
>
> Make this work again.
My fault.
Acked-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
>
> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
> ---
> drivers/mtd/maps/pxa2xx-flash.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/maps/pxa2xx-flash.c b/drivers/mtd/maps/pxa2xx-flash.c
> index 411a17d..2a25b67 100644
> --- a/drivers/mtd/maps/pxa2xx-flash.c
> +++ b/drivers/mtd/maps/pxa2xx-flash.c
> @@ -98,7 +98,7 @@ static int __devinit pxa2xx_flash_probe(struct platform_device *pdev)
> }
> info->mtd->owner = THIS_MODULE;
>
> - mtd_device_parse_register(info->mtd, probes, 0, NULL, 0);
> + mtd_device_parse_register(info->mtd, probes, 0, flash->parts, flash->nr_parts);
>
> platform_set_drvdata(pdev, info);
> return 0;
> --
> 1.7.7.2
>
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mtd: pxa2xx-flash.c: It used to fall back to provided table.
2011-11-11 17:06 ` [PATCH] mtd: pxa2xx-flash.c: It used to fall back to provided table Jonathan Cameron
2011-11-11 22:40 ` Dmitry Eremin-Solenikov
@ 2011-11-17 21:54 ` Artem Bityutskiy
2011-12-06 21:06 ` Artem Bityutskiy
2 siblings, 0 replies; 5+ messages in thread
From: Artem Bityutskiy @ 2011-11-17 21:54 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: dbaryshkov, dwmw2, linux-mtd, Jonathan Cameron
On Fri, 2011-11-11 at 17:06 +0000, Jonathan Cameron wrote:
> From: Jonathan Cameron <jic23@cam.ac.uk>
>
> Make this work again.
>
> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Pushed to l2-mtd-2.6.git, thanks!
Artem.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mtd: pxa2xx-flash.c: It used to fall back to provided table.
2011-11-11 17:06 ` [PATCH] mtd: pxa2xx-flash.c: It used to fall back to provided table Jonathan Cameron
2011-11-11 22:40 ` Dmitry Eremin-Solenikov
2011-11-17 21:54 ` Artem Bityutskiy
@ 2011-12-06 21:06 ` Artem Bityutskiy
2 siblings, 0 replies; 5+ messages in thread
From: Artem Bityutskiy @ 2011-12-06 21:06 UTC (permalink / raw)
To: Jonathan Cameron, dwmw2
Cc: dbaryshkov, Artem.Bityutskiy, linux-mtd, Jonathan Cameron
On Fri, 2011-11-11 at 17:06 +0000, Jonathan Cameron wrote:
> From: Jonathan Cameron <jic23@cam.ac.uk>
>
> Make this work again.
>
> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
I guess this should be sent to Linus this merge window. David?
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-12-06 21:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-11 17:06 [Regression PATCH] pxa2xx-flash.c: Not falling back to partition table as it previously did Jonathan Cameron
2011-11-11 17:06 ` [PATCH] mtd: pxa2xx-flash.c: It used to fall back to provided table Jonathan Cameron
2011-11-11 22:40 ` Dmitry Eremin-Solenikov
2011-11-17 21:54 ` Artem Bityutskiy
2011-12-06 21:06 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).