linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	linux-mtd@lists.infradead.org,
	Mike Frysinger <vapier.adi@gmail.com>,
	Kevin Cernekee <cernekee@gmail.com>
Subject: [PATCH 0/2] small mtd-utils fixes
Date: Wed, 16 Nov 2011 12:03:55 -0800	[thread overview]
Message-ID: <1321473837-27891-1-git-send-email-computersforpeace@gmail.com> (raw)

Hi,

These two fixes are somewhat trivial, although the second one fixes a
kind of regression that occurred since the last release.

Speaking of releases: when will we make a new release? After kernel 3.2
is final? Or perhaps a pre-3.2 and post-3.2 release? There are a lot of
important fixes in git right now, and I'd like to incorporate them
officially.

Also, note that the following commit was intended to be paired with the
commits in the "brian" branch:

    commit bf01f2960ba82468b1b25f00e044fd0c3ee0770a
    nandwrite: consolidate buffer usage

While it is functionally harmless, it does include an unnecessary
memcpy(). In fact, the patch really is useful only when paired with the
rest of the 'brian' branch, which is intended for kernels supporting
ioctl(MEMWRITE) - i.e., kernel version >= 3.2.

So I recommend that the next release either includes the 'brian' branch
or does not include commit bf01f2. Mike Frysinger and I discussed this
issue on the ML earlier and didn't really come up with a solution that
avoids the overhead both with and without MEMWRITE. I figure pre-3.2
kernel users will just have to put up with it eventually.

Thanks,
Brian

Brian Norris (2):
  mtd-utils: add jffs2reader to .gitignore
  mtdinfo: provide info when used without arguments

 .gitignore          |    1 +
 ubi-utils/mtdinfo.c |   14 ++++++++++----
 2 files changed, 11 insertions(+), 4 deletions(-)

-- 
1.7.5.4

             reply	other threads:[~2011-11-16 20:04 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-16 20:03 Brian Norris [this message]
2011-11-16 20:03 ` [PATCH 1/2] mtd-utils: add jffs2reader to .gitignore Brian Norris
2011-11-17  5:40   ` Mike Frysinger
2011-11-16 20:03 ` [PATCH 2/2] mtdinfo: provide info when used without arguments Brian Norris
2011-11-17  5:41   ` Mike Frysinger
2011-11-17 22:19 ` [PATCH 0/2] small mtd-utils fixes Artem Bityutskiy
2011-11-17 23:56   ` Brian Norris
2011-11-18 22:00     ` Artem Bityutskiy
2011-11-18 22:44       ` Peter Korsgaard
2011-11-18 23:37         ` Brian Norris
2011-11-19 20:47           ` Artem Bityutskiy
2011-11-19 20:55             ` Mike Frysinger
2011-11-19 23:04               ` Artem Bityutskiy
2011-11-20  8:41                 ` Mike Frysinger
2011-11-20 13:10                   ` Artem Bityutskiy
2011-11-20 11:55                 ` David Woodhouse
2011-11-20 13:08                   ` Artem Bityutskiy
2011-11-21  4:22                     ` Mike Frysinger
2011-11-22 21:38                       ` Artem Bityutskiy
2011-11-22 22:21                         ` Mike Frysinger
2011-11-23  7:45                           ` Artem Bityutskiy
2011-11-24  1:45                             ` Mike Frysinger
2011-11-24  7:26                               ` Artem Bityutskiy
2011-12-05  0:28                                 ` Mike Frysinger
2011-12-07  7:12                                   ` Artem Bityutskiy
2011-11-23  9:38                       ` Artem Bityutskiy
2011-11-22 22:21                     ` Mike Frysinger
2011-11-23  9:39                       ` Artem Bityutskiy
2011-11-17 22:22 ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321473837-27891-1-git-send-email-computersforpeace@gmail.com \
    --to=computersforpeace@gmail.com \
    --cc=cernekee@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).