Re: [PATCH 0/2] small mtd-utils fixes

[Artem Bityutskiy <dedekind1@gmail.com>]

On Sun, 2011-11-20 at 23:22 -0500, Mike Frysinger wrote:
> On Sun, Nov 20, 2011 at 08:08, Artem Bityutskiy wrote:
> > usage() {
> >        cat <<EOF
> > Usage: ${0##*/} <new_ver> <outdir>
> >
> > <new_ver>  - mtd utils version to create in X.Y.Z format
> > <outdir>   - the output directory where to store the tarball with the
> >             gpg signature
> > EOF
> >        exit 0
> > }
> 
> i'd have outdir be optional and default to $PWD
> 
> prob want to update .gitignore to ignore "mtd-utils-*.tar*"

Yeah, but this would require me to add options handling using getopt,
because optional parameters have to have an option. I just do not feel
it is necessary right now. This can be done at any point if someone
needs.

> 
> > # Change the version in the Makefile
> > tmpfile="$(mktemp)"
> > sed -e "s/^VERSION = [[:digit:]]\+\.[[:digit:]]\+\.[[:digit:]]\+/VERSION = $new_ver/" \
> >        Makefile > "$tmpfile"
> > mv "$tmpfile" Makefile
> 
> use `sed -i` and you won't need the $tmpfile at all

Good point, thanks, I'll do this.

> 
> > gpg --detach-sign -a "$outdir/$release_name.tar.bz2" > "$outdir/$release_name.tar.bz2.asc"
> 
> by using --detach-sign, you don't want the output redirection.  so
> delete the "> .......".

OK, I'll actually test this and fix.

> > echo "Created $outdir/$release_name.tar.bz2"
> > echo "Please, verify, then push the tag and upload the tarball and the signature"
> > echo "You can use these commands:"
> > echo "git push $tag_name"
> > echo "scp $outdir/$release_name.tar.bz2 $outdir/$release_name.tar.bz2.asc casper.infradead.org:/var/ftp/pub/mtd-utils"
> 
> if you really like, you could make this a single cat like in the usage()

Will do.

But now I have to go sleep, will send an updated patch in near future.
Thank you for suggestions.

Artem.