From: Jan Weitzel <j.weitzel@phytec.de>
To: linux-mtd@lists.infradead.org
Cc: dedekind@infradead.org, Jan Weitzel <j.weitzel@phytec.de>,
tglx@linutronix.de
Subject: [RFC] mtd/nand: modify NAND_CHIPOPTIONS_MSK
Date: Mon, 28 Nov 2011 15:20:40 +0100 [thread overview]
Message-ID: <1322490040-27161-1-git-send-email-j.weitzel@phytec.de> (raw)
Trying to set NAND_NO_SUBPAGE_WRITE from platform fail, because
nand_flash_detect_onfi options from struct nand_flash_dev overwrite the flag.
Removing NAND_NO_SUBPAGE_WRITE from NAND_CHIPOPTIONS_MSK fix this,
but setting it via struct nand_flash_dev table is not longer supported.
Signed-off-by: Jan Weitzel <j.weitzel@phytec.de>
---
include/linux/mtd/nand.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
index 904131b..babef5b 100644
--- a/include/linux/mtd/nand.h
+++ b/include/linux/mtd/nand.h
@@ -216,7 +216,8 @@ typedef enum {
&& (chip->page_shift > 9))
/* Mask to zero out the chip options, which come from the id table */
-#define NAND_CHIPOPTIONS_MSK (0x0000ffff & ~NAND_NO_AUTOINCR)
+#define NAND_CHIPOPTIONS_MSK \
+ (0x0000ffff & ~NAND_NO_AUTOINCR & ~NAND_NO_SUBPAGE_WRITE)
/* Non chip related options */
/* This option skips the bbt scan during initialization. */
--
1.7.0.4
next reply other threads:[~2011-11-28 14:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 14:20 Jan Weitzel [this message]
2011-11-28 18:34 ` [RFC] mtd/nand: modify NAND_CHIPOPTIONS_MSK Brian Norris
2011-11-29 9:00 ` [PATCH] mdt nand: omap2+ use platform options Jan Weitzel
2011-11-30 20:31 ` Brian Norris
2011-12-01 8:21 ` Jan Weitzel
2011-12-01 8:42 ` Artem Bityutskiy
2011-12-02 10:20 ` Grazvydas Ignotas
2011-12-02 11:10 ` Artem Bityutskiy
2011-12-02 17:28 ` Brian Norris
2011-12-04 14:29 ` Artem Bityutskiy
2011-12-05 8:11 ` Jan Weitzel
2011-12-05 10:32 ` Grazvydas Ignotas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322490040-27161-1-git-send-email-j.weitzel@phytec.de \
--to=j.weitzel@phytec.de \
--cc=dedekind@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox