[PATCH] mtd: gpmi: add missing include 'module.h'

linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] mtd: gpmi: add missing include 'module.h'
@ 2011-11-23 14:57 Wolfram Sang
  2011-11-24  3:01 ` Huang Shijie
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: Wolfram Sang @ 2011-11-23 14:57 UTC (permalink / raw)
  To: linux-mtd; +Cc: Huang Shijie, Wolfram Sang, Artem Bityutskiy

Fixes:

drivers/mtd/nand/gpmi-nand/gpmi-nand.c: In function 'gpmi_nfc_init':
drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: error: 'THIS_MODULE' undeclared (first use in this function)
drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: note: each undeclared identifier is reported only once for each function it appears in
drivers/mtd/nand/gpmi-nand/gpmi-nand.c: At top level:
drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:15: error: expected declaration specifiers or '...' before string constant
drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: data definition has no type or storage class
drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'

and some more...

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
---
 drivers/mtd/nand/gpmi-nand/gpmi-nand.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
index 071b634..493ec2f 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
@@ -21,9 +21,9 @@
 #include <linux/clk.h>
 #include <linux/slab.h>
 #include <linux/interrupt.h>
+#include <linux/module.h>
 #include <linux/mtd/gpmi-nand.h>
 #include <linux/mtd/partitions.h>
-
 #include "gpmi-nand.h"
 
 /* add our owner bbt descriptor */
-- 
1.7.7.1

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH] mtd: gpmi: add missing include 'module.h'
  2011-11-23 14:57 [PATCH] mtd: gpmi: add missing include 'module.h' Wolfram Sang
@ 2011-11-24  3:01 ` Huang Shijie
  2011-11-24  7:53   ` Wolfram Sang
  2011-11-24  8:58 ` Huang Shijie
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 10+ messages in thread
From: Huang Shijie @ 2011-11-24  3:01 UTC (permalink / raw)
  To: Wolfram Sang; +Cc: linux-mtd, Artem Bityutskiy

Hi Wolfram:

The ARCH part of the GPMI is not merged into mainline now.
I do not know why it can not be accepted. :(

How did compile the GPMI driver in such situation?

Best Regards
Huang Shijie
> Fixes:
>
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c: In function 'gpmi_nfc_init':
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: error: 'THIS_MODULE' undeclared (first use in this function)
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: note: each undeclared identifier is reported only once for each function it appears in
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c: At top level:
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:15: error: expected declaration specifiers or '...' before string constant
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: data definition has no type or storage class
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
>
> and some more...
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
>  drivers/mtd/nand/gpmi-nand/gpmi-nand.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index 071b634..493ec2f 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -21,9 +21,9 @@
>  #include <linux/clk.h>
>  #include <linux/slab.h>
>  #include <linux/interrupt.h>
> +#include <linux/module.h>
>  #include <linux/mtd/gpmi-nand.h>
>  #include <linux/mtd/partitions.h>
> -
>  #include "gpmi-nand.h"
>  
>  /* add our owner bbt descriptor */

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] mtd: gpmi: add missing include 'module.h'
  2011-11-24  3:01 ` Huang Shijie
@ 2011-11-24  7:53   ` Wolfram Sang
  0 siblings, 0 replies; 10+ messages in thread
From: Wolfram Sang @ 2011-11-24  7:53 UTC (permalink / raw)
  To: Huang Shijie; +Cc: linux-mtd, Artem Bityutskiy

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]


> The ARCH part of the GPMI is not merged into mainline now.
> I do not know why it can not be accepted. :(

Just resend it; this is quite normal, we are all too busy :/

> How did compile the GPMI driver in such situation?

I applied the arch-party manually.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] mtd: gpmi: add missing include 'module.h'
  2011-11-23 14:57 [PATCH] mtd: gpmi: add missing include 'module.h' Wolfram Sang
  2011-11-24  3:01 ` Huang Shijie
@ 2011-11-24  8:58 ` Huang Shijie
  2011-11-29 22:20 ` Artem Bityutskiy
  2011-12-02 19:47 ` Marek Vasut
  3 siblings, 0 replies; 10+ messages in thread
From: Huang Shijie @ 2011-11-24  8:58 UTC (permalink / raw)
  To: Wolfram Sang; +Cc: linux-mtd, Artem Bityutskiy

于 2011年11月23日 22:57, Wolfram Sang 写道:
> Fixes:
>
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c: In function 'gpmi_nfc_init':
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: error: 'THIS_MODULE' undeclared (first use in this function)
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: note: each undeclared identifier is reported only once for each function it appears in
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c: At top level:
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:15: error: expected declaration specifiers or '...' before string constant
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: data definition has no type or storage class
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
>
> and some more...
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
>  drivers/mtd/nand/gpmi-nand/gpmi-nand.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index 071b634..493ec2f 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -21,9 +21,9 @@
>  #include <linux/clk.h>
>  #include <linux/slab.h>
>  #include <linux/interrupt.h>
> +#include <linux/module.h>
>  #include <linux/mtd/gpmi-nand.h>
>  #include <linux/mtd/partitions.h>
> -
>  #include "gpmi-nand.h"
>  
>  /* add our owner bbt descriptor */
Acked-by: Huang Shijie <b32955@freescale.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] mtd: gpmi: add missing include 'module.h'
  2011-11-23 14:57 [PATCH] mtd: gpmi: add missing include 'module.h' Wolfram Sang
  2011-11-24  3:01 ` Huang Shijie
  2011-11-24  8:58 ` Huang Shijie
@ 2011-11-29 22:20 ` Artem Bityutskiy
  2011-12-02 19:47 ` Marek Vasut
  3 siblings, 0 replies; 10+ messages in thread
From: Artem Bityutskiy @ 2011-11-29 22:20 UTC (permalink / raw)
  To: Wolfram Sang; +Cc: Huang Shijie, linux-mtd

On Wed, 2011-11-23 at 15:57 +0100, Wolfram Sang wrote:
> Fixes:
> 
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c: In function 'gpmi_nfc_init':
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: error: 'THIS_MODULE' undeclared (first use in this function)
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: note: each undeclared identifier is reported only once for each function it appears in
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c: At top level:
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:15: error: expected declaration specifiers or '...' before string constant
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: data definition has no type or storage class
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'

Pushed to l2-mtd-2.6.git, thanks!

Artem.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] mtd: gpmi: add missing include 'module.h'
  2011-11-23 14:57 [PATCH] mtd: gpmi: add missing include 'module.h' Wolfram Sang
                   ` (2 preceding siblings ...)
  2011-11-29 22:20 ` Artem Bityutskiy
@ 2011-12-02 19:47 ` Marek Vasut
  2011-12-05  6:34   ` Artem Bityutskiy
  2011-12-13 22:15   ` Marek Vasut
  3 siblings, 2 replies; 10+ messages in thread
From: Marek Vasut @ 2011-12-02 19:47 UTC (permalink / raw)
  To: linux-mtd; +Cc: Huang Shijie, Wolfram Sang, Artem Bityutskiy

> Fixes:
> 
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c: In function 'gpmi_nfc_init':
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: error: 'THIS_MODULE'
> undeclared (first use in this function)
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: note: each undeclared
> identifier is reported only once for each function it appears in
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c: At top level:
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:15: error: expected declaration
> specifiers or '...' before string constant
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: data definition
> has no type or storage class
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: type defaults to
> 'int' in declaration of 'MODULE_AUTHOR'
> 
> and some more...
> 
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
>  drivers/mtd/nand/gpmi-nand/gpmi-nand.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c index 071b634..493ec2f 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -21,9 +21,9 @@
>  #include <linux/clk.h>
>  #include <linux/slab.h>
>  #include <linux/interrupt.h>
> +#include <linux/module.h>
>  #include <linux/mtd/gpmi-nand.h>

This one is missing too, but I suspect that's the stuff discussed in the 
subsequent emails? When do you plan to get this merged? (or what do I need to 
apply by hand ... patch name or message ID is ok).

Thanks

M

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] mtd: gpmi: add missing include 'module.h'
  2011-12-02 19:47 ` Marek Vasut
@ 2011-12-05  6:34   ` Artem Bityutskiy
  2011-12-13 22:15   ` Marek Vasut
  1 sibling, 0 replies; 10+ messages in thread
From: Artem Bityutskiy @ 2011-12-05  6:34 UTC (permalink / raw)
  To: Marek Vasut, dwmw2; +Cc: Huang Shijie, linux-mtd, Wolfram Sang

On Fri, 2011-12-02 at 20:47 +0100, Marek Vasut wrote:
> This one is missing too, but I suspect that's the stuff discussed in the 
> subsequent emails? When do you plan to get this merged? (or what do I need to 
> apply by hand ... patch name or message ID is ok).

Ah, right, this should be merged ASAP. Let's ask David to merge this
patch from my l2-mtd-2.6.git tree:

commit 63c646f21ef5bcde88a81b2695a450c4665857d4
Author: Wolfram Sang <w.sang@pengutronix.de>
Date:   Wed Nov 23 15:57:06 2011 +0100

    mtd: gpmi: add missing include 'module.h'
    
    Fixes:
    
    drivers/mtd/nand/gpmi-nand/gpmi-nand.c: In function 'gpmi_nfc_init':
    drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: error: 'THIS_MODULE' undeclared (first use in this function)
    drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: note: each undeclared identifier is reported only once for each function it appears in
    drivers/mtd/nand/gpmi-nand/gpmi-nand.c: At top level:
    drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:15: error: expected declaration specifiers or '...' before string constant
    drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: data definition has no type or storage class
    drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
    
    and some more...
    
    Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
    Acked-by: Huang Shijie <b32955@freescale.com>
    Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@intel.com>

Artem.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] mtd: gpmi: add missing include 'module.h'
  2011-12-02 19:47 ` Marek Vasut
  2011-12-05  6:34   ` Artem Bityutskiy
@ 2011-12-13 22:15   ` Marek Vasut
  2011-12-17 15:54     ` Artem Bityutskiy
  1 sibling, 1 reply; 10+ messages in thread
From: Marek Vasut @ 2011-12-13 22:15 UTC (permalink / raw)
  To: linux-mtd; +Cc: Huang Shijie, Wolfram Sang, Artem Bityutskiy

> > Fixes:
> > 
> > drivers/mtd/nand/gpmi-nand/gpmi-nand.c: In function 'gpmi_nfc_init':
> > drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: error: 'THIS_MODULE'
> > undeclared (first use in this function)
> > drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: note: each undeclared
> > identifier is reported only once for each function it appears in
> > drivers/mtd/nand/gpmi-nand/gpmi-nand.c: At top level:
> > drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:15: error: expected
> > declaration specifiers or '...' before string constant
> > drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: data definition
> > has no type or storage class
> > drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: type defaults to
> > 'int' in declaration of 'MODULE_AUTHOR'
> > 
> > and some more...
> > 
> > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> > ---
> > 
> >  drivers/mtd/nand/gpmi-nand/gpmi-nand.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> > b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c index 071b634..493ec2f 100644
> > --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> > +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> > @@ -21,9 +21,9 @@
> > 
> >  #include <linux/clk.h>
> >  #include <linux/slab.h>
> >  #include <linux/interrupt.h>
> > 
> > +#include <linux/module.h>
> > 
> >  #include <linux/mtd/gpmi-nand.h>
> 
> This one is missing too, but I suspect that's the stuff discussed in the
> subsequent emails? When do you plan to get this merged? (or what do I need
> to apply by hand ... patch name or message ID is ok).
> 
> Thanks
> 
> M

BUMP

any updates?
Thanks

M

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] mtd: gpmi: add missing include 'module.h'
  2011-12-13 22:15   ` Marek Vasut
@ 2011-12-17 15:54     ` Artem Bityutskiy
  2011-12-17 23:19       ` Marek Vasut
  0 siblings, 1 reply; 10+ messages in thread
From: Artem Bityutskiy @ 2011-12-17 15:54 UTC (permalink / raw)
  To: Marek Vasut; +Cc: Huang Shijie, linux-mtd, Wolfram Sang

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

On Tue, 2011-12-13 at 23:15 +0100, Marek Vasut wrote:
> BUMP

Ping David Woodhouse, it is his turn not send this to Linus.

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] mtd: gpmi: add missing include 'module.h'
  2011-12-17 15:54     ` Artem Bityutskiy
@ 2011-12-17 23:19       ` Marek Vasut
  0 siblings, 0 replies; 10+ messages in thread
From: Marek Vasut @ 2011-12-17 23:19 UTC (permalink / raw)
  To: dedekind1; +Cc: Huang Shijie, linux-mtd, Wolfram Sang, David.Woodhouse

> On Tue, 2011-12-13 at 23:15 +0100, Marek Vasut wrote:
> > BUMP
> 
> Ping David Woodhouse, it is his turn not send this to Linus.

Adding him to Cc

M

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2011-12-17 23:19 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-23 14:57 [PATCH] mtd: gpmi: add missing include 'module.h' Wolfram Sang
2011-11-24  3:01 ` Huang Shijie
2011-11-24  7:53   ` Wolfram Sang
2011-11-24  8:58 ` Huang Shijie
2011-11-29 22:20 ` Artem Bityutskiy
2011-12-02 19:47 ` Marek Vasut
2011-12-05  6:34   ` Artem Bityutskiy
2011-12-13 22:15   ` Marek Vasut
2011-12-17 15:54     ` Artem Bityutskiy
2011-12-17 23:19       ` Marek Vasut

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).