From: Artem Bityutskiy <dedekind1@gmail.com>
To: Mike Dunn <mikedunn@newsguy.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Scott Branden <sbranden@broadcom.com>,
Wan ZongShun <mcuos.com@gmail.com>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Manuel Lauss <manuel.lauss@googlemail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-mtd@lists.infradead.org, Ralf Baechle <ralf@linux-mips.org>,
Jiandong Zheng <jdzheng@broadcom.com>,
Andres Salomon <dilinger@queued.net>,
Olof Johansson <olof@lixom.net>, Jamie Iles <jamie@jamieiles.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Vimal Singh <vimal.newwork@gmail.com>
Subject: Re: [PATCH v2] MTD: modify mtd api to return bitflip info on read operations
Date: Mon, 05 Dec 2011 23:16:34 +0200 [thread overview]
Message-ID: <1323119796.2173.3.camel@koala> (raw)
In-Reply-To: <4EDD09E1.8070207@newsguy.com>
On Mon, 2011-12-05 at 10:13 -0800, Mike Dunn wrote:
> OK. But you may still be underestimating the quantity of code that warrants
> review. Since we're going back to multiple patches anyway, how about four patches:
>
> 1. api change to mtd.h (a few lines just to put the rest in context)
> 2. nand, onenand
> 3. mtd infrastructructure: mtdblock, mtdchar, mtdpart, mtdconcat, ...
> 4. rote changes
But you need to maintain bisectability. The kernel has to be compilable
and working between all these steps. The only way to do this is to add 2
new interfaces without removing the old ones, the do all the changes in
N stpes, then remove old interfaces. When I start thinking about that,
it looks too much, so I am not sure.
Artem.
prev parent reply other threads:[~2011-12-05 21:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-03 20:20 [PATCH v2] MTD: modify mtd api to return bitflip info on read operations Mike Dunn
2011-12-04 8:43 ` Peter Horton
2011-12-04 13:52 ` Mike Dunn
2011-12-04 14:43 ` Artem Bityutskiy
2011-12-04 14:55 ` Mike Dunn
2011-12-05 6:07 ` Artem Bityutskiy
2011-12-05 16:58 ` Mike Dunn
2011-12-05 17:09 ` Peter Horton
2011-12-05 18:57 ` Mike Dunn
2011-12-06 21:52 ` Robert Jarzmik
2011-12-07 2:16 ` Mike Dunn
2011-12-07 8:01 ` Ricard Wanderlof
2011-12-07 18:32 ` Mike Dunn
2011-12-12 12:48 ` Artem Bityutskiy
2011-12-14 20:46 ` Mike Dunn
2011-12-16 10:09 ` Artem Bityutskiy
2011-12-07 9:42 ` Peter Horton
2011-12-07 18:33 ` Mike Dunn
2011-12-04 14:33 ` Artem Bityutskiy
2011-12-05 6:23 ` Artem Bityutskiy
2011-12-05 18:13 ` Mike Dunn
2011-12-05 21:16 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323119796.2173.3.camel@koala \
--to=dedekind1@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=dbaryshkov@gmail.com \
--cc=dilinger@queued.net \
--cc=dwmw2@infradead.org \
--cc=haojian.zhuang@gmail.com \
--cc=jamie@jamieiles.com \
--cc=jdzheng@broadcom.com \
--cc=kyungmin.park@samsung.com \
--cc=lars@metafoo.de \
--cc=linux-mtd@lists.infradead.org \
--cc=manuel.lauss@googlemail.com \
--cc=mcuos.com@gmail.com \
--cc=mikedunn@newsguy.com \
--cc=olof@lixom.net \
--cc=ralf@linux-mips.org \
--cc=robert.jarzmik@free.fr \
--cc=sbranden@broadcom.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=vimal.newwork@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).