* [PATCH 4/6] jffs2: fix up error handling for insert_inode_locked [not found] <4EDE9D54.1030506@redhat.com> @ 2011-12-06 23:06 ` Eric Sandeen 2011-12-08 21:54 ` Artem Bityutskiy 0 siblings, 1 reply; 2+ messages in thread From: Eric Sandeen @ 2011-12-06 23:06 UTC (permalink / raw) To: linux-fsdevel@vger.kernel.org; +Cc: linux-mtd after 250df6ed274d767da844a5d9f05720b804240197 (fs: protect inode->i_state with inode->i_lock), insert_inode_locked() no longer returns the inode with I_NEW set on failure. However, the error handler still calls unlock_new_inode() on failure, which does a WARN_ON if I_NEW is not set, so any failure spews a lot of warnings. We can just drop the unlock_new_inode() if insert_inode_locked() fails here. Signed-off-by: Eric Sandeen <sandeen@redhat.com> --- diff --git a/fs/jffs2/fs.c b/fs/jffs2/fs.c index 4b8afe3..2e01238 100644 --- a/fs/jffs2/fs.c +++ b/fs/jffs2/fs.c @@ -466,7 +466,6 @@ struct inode *jffs2_new_inode (struct inode *dir_i, umode_t mode, struct jffs2_r if (insert_inode_locked(inode) < 0) { make_bad_inode(inode); - unlock_new_inode(inode); iput(inode); return ERR_PTR(-EINVAL); } ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4/6] jffs2: fix up error handling for insert_inode_locked 2011-12-06 23:06 ` [PATCH 4/6] jffs2: fix up error handling for insert_inode_locked Eric Sandeen @ 2011-12-08 21:54 ` Artem Bityutskiy 0 siblings, 0 replies; 2+ messages in thread From: Artem Bityutskiy @ 2011-12-08 21:54 UTC (permalink / raw) To: Eric Sandeen; +Cc: linux-fsdevel@vger.kernel.org, linux-mtd On Tue, 2011-12-06 at 17:06 -0600, Eric Sandeen wrote: > after 250df6ed274d767da844a5d9f05720b804240197 > (fs: protect inode->i_state with inode->i_lock), insert_inode_locked() > no longer returns the inode with I_NEW set on failure. However, > the error handler still calls unlock_new_inode() on failure, > which does a WARN_ON if I_NEW is not set, so any failure spews > a lot of warnings. > > We can just drop the unlock_new_inode() if insert_inode_locked() > fails here. > > Signed-off-by: Eric Sandeen <sandeen@redhat.com> Pushed to l2-mtd-2.6.git tree, thanks! Artem. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-08 21:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4EDE9D54.1030506@redhat.com>
2011-12-06 23:06 ` [PATCH 4/6] jffs2: fix up error handling for insert_inode_locked Eric Sandeen
2011-12-08 21:54 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).