From: Artem Bityutskiy <dedekind1@gmail.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH v3] mtd/docg3: fixes and cleanups
Date: Mon, 12 Dec 2011 23:13:05 +0200 [thread overview]
Message-ID: <1323724387.2297.13.camel@koala> (raw)
In-Reply-To: <877h2590zp.fsf@free.fr>
On Fri, 2011-12-09 at 17:13 +0100, Robert Jarzmik wrote:
> Artem Bityutskiy <dedekind1@gmail.com> writes:
>
> > On Fri, 2011-12-02 at 20:00 +0100, Robert Jarzmik wrote:
> >> This patch takes into account checkpatch, sparse and ECC
> >> comments.
> >>
> >> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> >
> > Pushed to l2-mtd-2.6.git, thanks. But I still see this warning when
> > I compile on x86_64:
> >
> > drivers/mtd/devices/docg3.c:1050:12: warning: ‘doc_get_erase_count’ defined
> > but not used [-Wunused-function]
>
> Hi Artem,
>
> I have found no clean and good way to handle the erase count. As a fallback,
> please accept the following patch which removes the unused function. It's kind
> of a "looser" approach, but that's the best I can do by now.
What do you mean by "handle" ? Is the problem that docg3 maintains
per-eraseblock erase-counters and you do not know how to use them? May
be it is better to just embrace this function with "#ifdef 0" and add a
comment that we can do this but do not have a good use for this?
Artem.
next prev parent reply other threads:[~2011-12-12 21:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 22:09 [PATCH v2] mtd/docg3: fixes and cleanups Robert Jarzmik
2011-12-01 8:05 ` Artem Bityutskiy
2011-12-02 18:57 ` Robert Jarzmik
2011-12-02 19:00 ` [PATCH v3] " Robert Jarzmik
2011-12-05 6:31 ` Artem Bityutskiy
2011-12-07 20:45 ` Robert Jarzmik
2011-12-09 16:13 ` Robert Jarzmik
2011-12-12 21:13 ` Artem Bityutskiy [this message]
2011-12-12 22:03 ` Robert Jarzmik
2011-12-13 4:16 ` Mike Dunn
2011-12-16 22:25 ` Robert Jarzmik
2011-12-17 15:08 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323724387.2297.13.camel@koala \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox