From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Ira W. Snyder" <iws@ovro.caltech.edu>
Cc: linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Florian Fainelli <ffainelli@freebox.fr>
Subject: Re: [PATCH] cfi: AMD/Fujitsu compatibles: add panic write support
Date: Wed, 11 Jan 2012 00:06:26 +0200 [thread overview]
Message-ID: <1326233187.2335.15.camel@koala> (raw)
In-Reply-To: <20120110163845.GA30403@ovro.caltech.edu>
On Tue, 2012-01-10 at 08:38 -0800, Ira W. Snyder wrote:
> On Tue, Jan 10, 2012 at 11:26:23AM +0100, Florian Fainelli wrote:
> > Hello,
> >
> > On 01/06/12 20:29, Ira W. Snyder wrote:
> > > This allows the mtdoops driver to work on flash chips using the
> > > AMD/Fujitsu compatible command set.
> > >
> > > As the code comments note, the locks used throughout the normal code
> > > paths in the driver are ignored, so that the chance of writing out the
> > > kernel's last messages are maximized.
> >
> > This patch made me looking at the panic code, but should not this be
> > made conditionnal to the enabling/disabling of the MTD oops driver?
> >
>
> It is reasonable to make this code conditional based on CONFIG_MTD_OOPS.
> The mtdoops driver is the only user of mtd->panic_write().
I think we should not break layering - the driver should not know about
entities like mtdoops which are at upper layers. It is like making a
disk driver conditional on file-systems.
Artem.
next prev parent reply other threads:[~2012-01-10 22:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 19:29 [PATCH] cfi: AMD/Fujitsu compatibles: add panic write support Ira W. Snyder
2012-01-10 10:26 ` Florian Fainelli
2012-01-10 16:38 ` Ira W. Snyder
2012-01-10 22:06 ` Artem Bityutskiy [this message]
2012-01-10 22:04 ` Artem Bityutskiy
2012-01-10 22:15 ` Florian Fainelli
2012-01-10 22:22 ` Artem Bityutskiy
2012-01-11 17:04 ` Florian Fainelli
2012-01-11 17:52 ` Artem Bityutskiy
2012-01-11 17:56 ` David Woodhouse
2012-01-10 22:13 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326233187.2335.15.camel@koala \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ffainelli@freebox.fr \
--cc=iws@ovro.caltech.edu \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox