From: Artem Bityutskiy <dedekind1@gmail.com>
To: Thomas Cannon <mail@thomascannon.net>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] libmtd: Variable name same as function name causing compile to fail (Android)
Date: Fri, 13 Jan 2012 23:59:32 +0200 [thread overview]
Message-ID: <1326491973.2258.1.camel@koala> (raw)
In-Reply-To: <CAGaKrsmCb6jHZ+oYjQiV8kU63-DQMpzwTG4pR-Jf_aTE1K2=NQ@mail.gmail.com>
On Mon, 2012-01-09 at 16:20 +0000, Thomas Cannon wrote:
> When compiling mtd-utils against Android's bionic libc using the
> supplied cross compiler environment it errors:
>
> lib/libmtd.c: In function 'dev_node2num':
> lib/libmtd.c:444: error: called object 'major' is not a function
> lib/libmtd.c:445: error: called object 'minor' is not a function
> lib/libmtd.c: In function 'mtd_probe_node':
> lib/libmtd.c:1384: error: called object 'major' is not a function
> lib/libmtd.c:1385: error: called object 'minor' is not a function
>
> This patch updates the variable names for "major" and "minor" in two
> places. It then compiles cleanly.
I've tweaked the patch a bit and picked different names: mjr and mnr
instead of strange majorx and minorx. I've also re-named major1 and
minor1 variables for consistency.
Pushed to mtd-utils.git, thanks!
Artem.
prev parent reply other threads:[~2012-01-13 21:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 16:20 [PATCH] libmtd: Variable name same as function name causing compile to fail (Android) Thomas Cannon
2012-01-13 21:59 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326491973.2258.1.camel@koala \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=mail@thomascannon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox