From: Artem Bityutskiy <dedekind1@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ubi: Use UBI_LAYOUT_VOLUME_{TYPE, ALIGN}
Date: Sat, 14 Jan 2012 17:38:33 +0200 [thread overview]
Message-ID: <1326555513.14299.7.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <4F11A06A.3040703@nod.at>
[-- Attachment #1: Type: text/plain, Size: 978 bytes --]
On Sat, 2012-01-14 at 16:34 +0100, Richard Weinberger wrote:
> Am 14.01.2012 16:11, schrieb Artem Bityutskiy:
> > On Tue, 2012-01-10 at 17:57 +0100, Richard Weinberger wrote:
> >> UBI_LAYOUT_VOLUME_TYPE and UBI_LAYOUT_VOLUME_ALIGN are currently
> >> defined but not used.
> >> Use them at least once. 8-)
> >>
> >> Signed-off-by: Richard Weinberger <richard@nod.at>
> >
> > Hi Richard,
> >
> > This will break backward compatibility - older and current kernels which
> > do not have this patch will error out when the find a volume without a
> > name. The right way to do this would be to change the UBI format
> > version, but you would need a really strong reason for this.
> >
>
> Sorry, this comment makes absolutely no sense.
>
> Did you mean my other patch?
> But still, the other patch also does *not* allow volumes without names.
Yes, sorry, ignore this one - I've pushed your patch.
(Embarrassed)
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-01-14 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 16:57 [PATCH] ubi: Use UBI_LAYOUT_VOLUME_{TYPE, ALIGN} Richard Weinberger
2012-01-14 15:11 ` Artem Bityutskiy
2012-01-14 15:34 ` Richard Weinberger
2012-01-14 15:38 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326555513.14299.7.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox