From: Brian Norris <computersforpeace@gmail.com>
To: <linux-mtd@lists.infradead.org>
Cc: Angus CLARK <angus.clark@st.com>,
Dan Carpenter <error27@gmail.com>,
Kulikov Vasiliy <segooon@gmail.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Peter Wippich <pewi@gw-instruments.de>,
Gabor Juhos <juhosg@openwrt.org>,
Guillaume LECERF <glecerf@gmail.com>,
Jonas Gorski <jonas.gorski@gmail.com>,
Jamie Iles <jamie@jamieiles.com>,
Ivan Djelic <ivan.djelic@parrot.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
David Woodhouse <David.Woodhouse@intel.com>,
Maxim Levitsky <maximlevitsky@gmail.com>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
Kevin Cernekee <cernekee@gmail.com>,
Barry Song <21cnbao@gmail.com>,
Jim Quinlan <jim2101024@gmail.com>,
Andres Salomon <dilinger@queued.net>,
Axel Lin <axel.lin@gmail.com>, Anatolij Gustschin <agust@denx.de>,
Mike Frysinger <vapier@gentoo.org>, Arnd Bergmann <arnd@arndb.de>,
Lei Wen <leiwen@marvell.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Artem Bityutskiy <artem.bityutskiy@intel.com>,
Florian Fainelli <florian@openwrt.org>,
Ricard Wanderlof <ricard.wanderlof@axis.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Matthieu CASTET <matthieu.castet@parrot.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Shmulik Ladkani <shmulik.ladkani@gmail.com>,
Wolfram Sang <w.sang@pengutronix.de>,
Chuanxiao Dong <chuanxiao.dong@intel.com>,
Joe Perches <joe@perches.com>,
Brian Norris <computersforpeace@gmail.com>,
Roman Tereshonkov <roman.tereshonkov@nokia.com>
Subject: [PATCH v4 0/2] write OOB BBM + flash-based BBT
Date: Fri, 20 Jan 2012 20:38:02 -0800 [thread overview]
Message-ID: <1327120684-7066-1-git-send-email-computersforpeace@gmail.com> (raw)
Hi,
It looks like we have some consensus that:
- OOB markers are not a guaranteed reliable method for tracking bad blocks
- We should work to make flash-based BBT a reliable, primary source of bad
block information
- There are occasions where having bad block markers in OOB is important,
so we should make a best effort to write bad block markers even when
using flash-based BBT
- Some users do not want to write bad block markers to OOB for one reason
or another; so we provide an option (bbt_options) that will prevent this
Thus, this is yet another iteration of my patch(es) to write bad block data
to both the OOB area and the flash-based BBT when marking new bad blocks.
They try to accomodate for some of the issues brought up in previous
threads. Please comment if more changes are necessary or if I introduced
crazy ones.
This series consists of a small fixup patch followed by the main
substantial patch.
I will highlight a few things here, but see the patch descriptions for
details.
I re-ordered nand_default_block_markbad() so that BBM is written before
BBT, for power cut reasons, and since when available, we mostly use
flash-based BBT as the "primary" source of information.
v4: re-order operations so we write BBM before BBT. This should help with
power cuts. Option for old behavior changed to NAND_BBT_NO_OOB_BBM,
use in chip->bbt_options.
v3: writing to flash-based BBT and to BBM is still default, but
there is a new option NAND_NO_WRITE_OOB that can prevent writing the
BBM as well as prevent all other OOB writes.
Thanks,
Brian
Brian Norris (2):
mtd: nand: move SCANLASTPAGE handling to the correct code block
mtd: nand: write BBM to OOB even with flash-based BBT
drivers/mtd/nand/nand_base.c | 54 +++++++++++++++++++++++++++--------------
include/linux/mtd/bbm.h | 5 ++++
2 files changed, 40 insertions(+), 19 deletions(-)
--
1.7.5.4
next reply other threads:[~2012-01-21 4:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-21 4:38 Brian Norris [this message]
2012-01-21 4:38 ` [PATCH v4 1/2] mtd: nand: move SCANLASTPAGE handling to the correct code block Brian Norris
2012-01-27 14:56 ` Bityutskiy, Artem
2012-01-28 20:09 ` Brian Norris
2012-01-21 4:38 ` [PATCH v4 2/2] mtd: nand: write BBM to OOB even with flash-based BBT Brian Norris
2012-01-21 9:57 ` Shmulik Ladkani
2012-01-21 10:10 ` Shmulik Ladkani
2012-01-23 21:31 ` Brian Norris
2012-02-02 8:12 ` Bityutskiy, Artem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327120684-7066-1-git-send-email-computersforpeace@gmail.com \
--to=computersforpeace@gmail.com \
--cc=21cnbao@gmail.com \
--cc=David.Woodhouse@intel.com \
--cc=adrian.hunter@intel.com \
--cc=agust@denx.de \
--cc=angus.clark@st.com \
--cc=arnd@arndb.de \
--cc=artem.bityutskiy@intel.com \
--cc=axel.lin@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=cernekee@gmail.com \
--cc=chuanxiao.dong@intel.com \
--cc=dbaryshkov@gmail.com \
--cc=dilinger@queued.net \
--cc=error27@gmail.com \
--cc=florian@openwrt.org \
--cc=glecerf@gmail.com \
--cc=ivan.djelic@parrot.com \
--cc=jamie@jamieiles.com \
--cc=jim2101024@gmail.com \
--cc=joe@perches.com \
--cc=jonas.gorski@gmail.com \
--cc=juhosg@openwrt.org \
--cc=kyungmin.park@samsung.com \
--cc=leiwen@marvell.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@dominikbrodowski.net \
--cc=matthieu.castet@parrot.com \
--cc=maximlevitsky@gmail.com \
--cc=nicolas.ferre@atmel.com \
--cc=pewi@gw-instruments.de \
--cc=ricard.wanderlof@axis.com \
--cc=robert.jarzmik@free.fr \
--cc=roman.tereshonkov@nokia.com \
--cc=s.hauer@pengutronix.de \
--cc=segooon@gmail.com \
--cc=shmulik.ladkani@gmail.com \
--cc=vapier@gentoo.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox