From: Artem Bityutskiy <dedekind1@gmail.com>
To: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Cc: MTD Maling List <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 1/3] mtd: remove retlen zeroing duplication
Date: Tue, 07 Feb 2012 10:02:37 +0200 [thread overview]
Message-ID: <1328601757.22240.46.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20120207094715.63ffbe78@pixies.home.jungo.com>
[-- Attachment #1: Type: text/plain, Size: 759 bytes --]
On Tue, 2012-02-07 at 09:47 +0200, Shmulik Ladkani wrote:
> On Mon, 6 Feb 2012 14:03:07 +0200 Artem Bityutskiy <dedekind1@gmail.com> wrote:
> > From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> >
> > The MTD API function now zero the 'retlen' parameter before calling
> > the driver's method - do not do this again in dirvers. This removes
> > duplicated '*retlen = 0' assignent from the following methods:
> >
> > 'mtd_point()'
> > 'mtd_read()'
> > 'mtd_write()'
> > 'mtd_writev()'
> > 'mtd_panic_write()'
> >
>
> Seems that '*retlen = 0' is missing from mtd_read() in l2-mtd.
> Deliberately? or am I looking at the wrong repo?
Not, oversight, fixed in the repo.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-02-07 8:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 12:03 [PATCH 1/3] mtd: remove retlen zeroing duplication Artem Bityutskiy
2012-02-06 12:03 ` [PATCH 2/3] mtd: move zero length verification to MTD API functions Artem Bityutskiy
2012-02-07 12:35 ` Shmulik Ladkani
2012-02-08 12:42 ` Artem Bityutskiy
2012-02-08 13:26 ` Artem Bityutskiy
2012-02-08 14:54 ` Shmulik Ladkani
2012-02-08 16:06 ` Artem Bityutskiy
2012-02-06 12:03 ` [PATCH 3/3] mtd: remove junk pmc551.h Artem Bityutskiy
2012-02-07 7:47 ` [PATCH 1/3] mtd: remove retlen zeroing duplication Shmulik Ladkani
2012-02-07 8:02 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328601757.22240.46.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=shmulik.ladkani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox