From: Artem Bityutskiy <dedekind1@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Brian Foster <brian.foster@maxim-ic.com>, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/3] libmtd: perform device checking first
Date: Thu, 09 Feb 2012 14:05:46 +0200 [thread overview]
Message-ID: <1328789146.22240.82.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1328736382-5798-1-git-send-email-computersforpeace@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
On Wed, 2012-02-08 at 13:26 -0800, Brian Norris wrote:
> If we don't check for the MTD before calling `legacy_get_dev_info1', we may
> get errors like:
>
> libmtd: MTD subsystem is old and does not support sysfs, so MTD character device nodes have to exist
> libmtd: error!: "/dev/mtd2" is not a character device
> mtdinfo: error!: libmtd failed get MTD device 2 information
> error 22 (Invalid argument)
>
> So reverse the order of these two checks.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Looks good, thanks, but could you please send a version which applies to
mtd-utils.git? The 3rd patch in this series does not apply.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-09 12:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 21:26 [PATCH 1/3] libmtd: perform device checking first Brian Norris
2012-02-08 21:26 ` [PATCH 2/3] libmtd_legacy: don't open device in R/W Brian Norris
2012-02-08 21:26 ` [PATCH 3/3] libmtd: fix segmentation fault on lib->mtd Brian Norris
2012-02-09 12:05 ` Artem Bityutskiy [this message]
2012-02-09 12:07 ` [PATCH 1/3] libmtd: perform device checking first Artem Bityutskiy
2012-02-09 18:14 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328789146.22240.82.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=brian.foster@maxim-ic.com \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox