From: Artem Bityutskiy <dedekind1@gmail.com>
To: Hong Xu <hong.xu@atmel.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Cc: dwmw2@infradead.org, ivan.djelic@parrot.com,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH V3] MTD: atmel_nand: Update driver to support Programmable HW ECC controller
Date: Sat, 11 Feb 2012 13:28:12 +0200 [thread overview]
Message-ID: <1328959692.22240.103.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1328491977-30448-1-git-send-email-hong.xu@atmel.com>
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
On Mon, 2012-02-06 at 09:32 +0800, Hong Xu wrote:
> +static int16_t *pmecc_get_index_of(struct atmel_nand_host *host)
> +{
> + int16_t *p = (int16_t *)host->rom_base;
I did not really get into details, but you annotate rom_base with
__iomem, and then you have to cast it to int16_t in several - this does
not look very nice.
Could you please CC the arm list? There are much more people who can
give this code a review.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-11 11:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 1:32 [PATCH V3] MTD: atmel_nand: Update driver to support Programmable HW ECC controller Hong Xu
2012-02-11 11:28 ` Artem Bityutskiy [this message]
2012-02-13 2:15 ` Xu, Hong
2012-02-13 2:41 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328959692.22240.103.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=hong.xu@atmel.com \
--cc=ivan.djelic@parrot.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox