Re: [PATCH 0/4] jffs2: logging message neatening

Artem Bityutskiy
2012-02-29T12:05:47Z

[-- Attachment #1: Type: text/plain, Size: 3771 bytes --]

On Wed, 2012-02-15 at 15:56 -0800, Joe Perches wrote:
> Joe Perches (4):
> jffs2: Convert most D1/D2 macros to jffs2_dbg
> jffs2: Convert printks to pr_<level>
> jffs2: Use pr_fmt and remove jffs: from formats
> jffs2: Standardize JFFS_<LEVEL> uses

Thanks for the work, appreciated. But your patch introduces new sparse
and smatch warnings, which did not exist before your patch:

Successfully built configuration "l2_mxs_defconfig,arm,arm-unknown-linux-gnueabi-", results:

--- before_patching.log
+++ after_patching.log
@@ @@
+fs/jffs2/file.c:330:2: warning: signed and unsigned type in conditional expression [-Wsign-compare]
@@ @@
-fs/jffs2/read.c:154 jffs2_read_dnode(129) warn: possible memory leak of 'decomprbuf' [smatch]
-fs/jffs2/read.c:154 jffs2_read_dnode(129) warn: possible memory leak of 'readbuf' [smatch]
+fs/jffs2/read.c:154 jffs2_read_dnode(131) warn: possible memory leak of 'decomprbuf' [smatch]
+fs/jffs2/read.c:154 jffs2_read_dnode(131) warn: possible memory leak of 'readbuf' [smatch]
@@ @@
-fs/jffs2/scan.c:108:54: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
@@ @@
+fs/jffs2/super.c:377:1: error: directive in argument list [sparse]
+fs/jffs2/super.c:379:1: error: directive in argument list [sparse]
+fs/jffs2/super.c:380:1: error: directive in argument list [sparse]
+fs/jffs2/super.c:382:1: error: directive in argument list [sparse]

Would you please take a look? Ideally patches should eliminate warnings,
not introduce new ones.

Also, your patch does not apply cleanly to my l2-mtd tree - and this is
the tree which is currently used for merging MTD and JFFS2 stuff
upstream, and it is in linux-next as well. Would you send patches
against the l2 tree?

Also, there are several checkpatch.pl complaints, please, take a look:

--------------------------------------------------------------------------------

checkpatch.pl has some complaints:

--------------------------------------------------------------------------------

checkpatch.pl results for patch "[PATCH 2/4] jffs2: Convert printks to pr_<level>"

WARNING:LONG_LINE: line over 80 characters
#893: FILE: fs/jffs2/nodemgmt.c:269:
+ list_empty(&c->erase_pending_list) ? "yes" : "no");

WARNING:LONG_LINE: line over 80 characters
#1094: FILE: fs/jffs2/scan.c:31:
+ pr_notice("Further such events for this erase block will not be printed\n"); \

total: 0 errors, 2 warnings, 1523 lines checked

--------------------------------------------------------------------------------

checkpatch.pl results for patch "[PATCH 3/4] jffs2: Use pr_fmt and remove jffs: from formats"

WARNING:LONG_LINE: line over 80 characters
#102: FILE: fs/jffs2/build.c:312:
+ dbg_fsbuild("trigger levels (size %d KiB, block size %d KiB, %d blocks)\n",

total: 0 errors, 1 warnings, 432 lines checked

--------------------------------------------------------------------------------

checkpatch.pl results for the entire squashed patch-set

WARNING:LONG_LINE: line over 80 characters
#3480: FILE: fs/jffs2/nodemgmt.c:269:
+ list_empty(&c->erase_pending_list) ? "yes" : "no");

WARNING:LONG_LINE: line over 80 characters
#3681: FILE: fs/jffs2/scan.c:31:
+ pr_notice("Further such events for this erase block will not be printed\n"); \

WARNING:LONG_LINE: line over 80 characters
#4448: FILE: fs/jffs2/build.c:312:
+ dbg_fsbuild("trigger levels (size %d KiB, block size %d KiB, %d blocks)\n",

total: 0 errors, 3 warnings, 4324 lines checked

--------------------------------------------------------------------------------

--
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]