Re: [PATCH 1/4] jffs2: Convert most D1/D2 macros to jffs2_dbg

Artem Bityutskiy
2012-03-13T12:36:55Z

[-- Attachment #1: Type: text/plain, Size: 740 bytes --]

On Mon, 2012-03-12 at 10:11 -0700, Joe Perches wrote:
> On Mon, 2012-03-12 at 18:35 +0200, Artem Bityutskiy wrote:
> > On Mon, 2012-03-12 at 08:33 -0700, Joe Perches wrote:
> > > I tentatively converted them to a bitmap
> > > and a single jffs2_dbg(mask, fmt, ...)
> > > but perhaps all of these could be deleted
> > > too.
> >
> > I think it is better to convert them to jffs2_debug(). And I guess after
> > the change the "mask" parameter will go away?
>
> Mask would remain and perhaps become a module
> variable instead of a compile #define.
>
> What is jffs2_debug?

Sorry, I meant to suggest to just turn them all to jffs2_dbg() which you
introduced, without any bitmasks.

--
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]