Re: [RFC][PATCH 0/7] UBI checkpointing support

Artem Bityutskiy
2012-02-29T11:58:57Z

[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]

On Wed, 2012-02-29 at 12:40 +0100, Richard Weinberger wrote:
> Am 29.02.2012 12:35, schrieb Artem Bityutskiy:
> > On Tue, 2012-02-14 at 21:06 +0100, Richard Weinberger wrote:
> >> The following patch set implements checkpointing support for
> >> UBI. Checkpointing is an optional feature which stores the physical to
> >> logical eraseblock relations in a checkpointing superblock to reduce
> >> the initialization time of UBI. The current init time of UBI is
> >> proportional to the number of physical erase blocks on the FLASH
> >> device. With checkpointing enabled the scan time is limited to a fixed
> >> number of blocks.
> >
> > Notice, your patch-set has huge amount of checkpatch.pl complaints -
> > please fix them. This will also be consistent with the overall UBI
> > coding style where I honored checkpatch.pl limitations like identation
> > style and 80 chars per line.
> >
>
> All checkpatch.pl complaints will be fixed.
> But first we have to discuss and address real problems.

Sure, I just to not have time to look at real stuff now.

But yes, I assume you will come up with a good way to stress-test it.
You will look how the unstable bits problem affects the checkpointing. I
would suggest you to implement power-cut emulation in UBI just like we
have it in UBIFS, then run the integck test which already supports UBIFS
power cut emulation. This will allow to catch a lot of issues.

--
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]