From: Artem Bityutskiy <dedekind1@gmail.com>
To: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Cc: Josselin Costanzi <josselin.costanzi@mobile-devices.fr>,
MTD Maling List <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 1/2] UBI: allocate verification buffer on demand
Date: Fri, 09 Mar 2012 09:45:09 +0200 [thread overview]
Message-ID: <1331279109.22872.22.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20120308180826.53123148@halley>
On Thu, 2012-03-08 at 18:08 +0200, Shmulik Ladkani wrote:
> On Thu, 8 Mar 2012 16:14:50 +0200 Artem Bityutskiy <dedekind1@gmail.com> wrote:
> > From: Josselin Costanzi <josselin.costanzi@mobile-devices.fr>
> >
> > Remove the pre-allocated 'peb_buf2' buffer because we do not really need it.
> > The only reason UBI has it is to check that the data were written correctly.
> > But we do not have to have 2 buffers for this and waste RAM - we can just
> > compare CRC checksums instead.
> >
> > Artem bityutskiy: massaged the patch and commit message
> >
> > Signed-off-by: Josselin Costanzi <josselin.costanzi@mobile-devices.fr>
> > Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
>
> Josselin's original title "allocate verification buffer on demand" does
> no longer describe this patch.
> Should be "Remove the pre-allocated 'peb_buf2'" or alike.
Fixed as well and pushed out, thanks! Waiting for Josselin's reply
anyway.
commit 43b043e78b876ce27034f167897b57fd2556ad29
Author: Josselin Costanzi <josselin.costanzi@mobile-devices.fr>
Date: Wed Feb 22 16:37:05 2012 +0100
UBI: reduce memory consumption
Remove the pre-allocated 'peb_buf2' buffer because we do not really need it.
The only reason UBI has it is to check that the data were written correctly.
But we do not have to have 2 buffers for this and waste RAM - we can just
compare CRC checksums instead. This reduces UBI memory consumption.
Artem bityutskiy: massaged the patch and commit message
Signed-off-by: Josselin Costanzi <josselin.costanzi@mobile-devices.fr>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2012-03-09 7:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 14:14 [PATCH 1/2] UBI: allocate verification buffer on demand Artem Bityutskiy
2012-03-08 14:14 ` [PATCH 2/2] UBI: rename peb_buf1 to peb_buf Artem Bityutskiy
2012-03-08 16:08 ` [PATCH 1/2] UBI: allocate verification buffer on demand Shmulik Ladkani
2012-03-09 7:45 ` Artem Bityutskiy [this message]
2012-03-09 9:13 ` Josselin Costanzi
2012-03-09 16:42 ` Josselin Costanzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331279109.22872.22.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=josselin.costanzi@mobile-devices.fr \
--cc=linux-mtd@lists.infradead.org \
--cc=shmulik.ladkani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox