public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org, Mike Frysinger <vapier.adi@gmail.com>
Subject: Re: [PATCH (mtd-utils)] Makefile: fix "make clean" for old GNU find
Date: Fri, 09 Mar 2012 11:41:39 +0200	[thread overview]
Message-ID: <1331286099.22872.45.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <CAN8TOE9yLLnV2_imd0GUbue+z0A2PNdD6Vz7qr2dYaVjsugN=w@mail.gmail.com>

On Thu, 2012-03-08 at 09:52 -0800, Brian Norris wrote:
> On Thu, Mar 8, 2012 at 8:54 AM, Mike Frysinger <vapier.adi@gmail.com> wrote:
> > On Fri, Mar 2, 2012 at 17:17, Brian Norris <computersforpeace@gmail.com> wrote:
> >> However, it will launch a lot more `rm' processes...
> >
> > indeed, that does suck.  you could do this, but it kind of sucks too ...
> > CLEAN_FIND = find "$(BUILDDIR)/" -xdev '(' -name '*.[ao]' -o -name
> > '.*.c.dep' ')'
> > ...
> >    @if test -d "$(BUILDDIR)/"; then
> >        $(CLEAN_FIND) -exec rm -f {} + 2>/dev/null || \
> >        $(CLEAN_FIND) -exec rm -f {} \; ; \
> >    fi
> 
> I'm fine with that too. It's a little uglier, but it's not quite as
> bad for systems that have a modern `find', I think. I'll resend with
> your suggestion if there are no better suggestions.

May be adding a one-line comment like "work-around for ancient find
utils not supporting '+'" would also be a good idea?

-- 
Best Regards,
Artem Bityutskiy

  reply	other threads:[~2012-03-09  9:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-02 22:17 [PATCH (mtd-utils)] Makefile: fix "make clean" for old GNU find Brian Norris
2012-03-08 16:54 ` Mike Frysinger
2012-03-08 17:52   ` Brian Norris
2012-03-09  9:41     ` Artem Bityutskiy [this message]
2012-03-09 17:46       ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331286099.22872.45.camel@sauron.fi.intel.com \
    --to=dedekind1@gmail.com \
    --cc=computersforpeace@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox