From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com ([134.134.136.24]) by bombadil.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1S5yMp-0000Mj-1k for linux-mtd@lists.infradead.org; Fri, 09 Mar 2012 11:52:15 +0000 Message-ID: <1331294012.29445.10.camel@sauron.fi.intel.com> Subject: Re: [PATCH 1/4] jffs2: Convert most D1/D2 macros to jffs2_dbg From: Artem Bityutskiy To: Joe Perches Date: Fri, 09 Mar 2012 13:53:32 +0200 In-Reply-To: <1330966615.3140.6.camel@joe2Laptop> References: <2d68e76db16d42f451370714f03ef952e0839692.1329349881.git.joe@perches.com> <1330965033.7220.16.camel@golum> <1330966615.3140.6.camel@joe2Laptop> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Cc: linux-mtd@lists.infradead.org, David Woodhouse , linux-kernel@vger.kernel.org Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2012-03-05 at 08:56 -0800, Joe Perches wrote: > On Mon, 2012-03-05 at 18:30 +0200, Artem Bityutskiy wrote: > > On Wed, 2012-02-15 at 15:56 -0800, Joe Perches wrote: > [] > > I would just kill all the levels and left only the first one - others > > are not useful. This FS is in the kernel for ages and it is safe to > > assume it is robust enough to require no level 2. And change the Kconfig > > correspondingly. > > > > I would accept that to my l2 tree, although the final word is from > > dwmw2, of course. > > Separate patch I think. OK, pushed these ones, although I think that mechanical D1->jffs2_dbg() conversion is not very useful and to make your patch-set worth the trouble you should do few more clean-up steps, like I suggested. Let's push these patches as they are anyway to make sure the work you have done does not get lost. Pushed to l2-mtd.git, thanks! -- Best Regards, Artem Bityutskiy