From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com ([192.55.52.93]) by casper.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1S750b-0000Tc-H3 for linux-mtd@lists.infradead.org; Mon, 12 Mar 2012 13:09:54 +0000 Message-ID: <1331557935.12037.11.camel@sauron.fi.intel.com> Subject: Re: [PATCH 1/4] jffs2: Convert most D1/D2 macros to jffs2_dbg From: Artem Bityutskiy To: Joe Perches Date: Mon, 12 Mar 2012 15:12:15 +0200 In-Reply-To: <1331318968.13055.8.camel@joe2Laptop> References: <2d68e76db16d42f451370714f03ef952e0839692.1329349881.git.joe@perches.com> <1330965033.7220.16.camel@golum> <1330966615.3140.6.camel@joe2Laptop> <1331294012.29445.10.camel@sauron.fi.intel.com> <1331318968.13055.8.camel@joe2Laptop> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Cc: linux-mtd@lists.infradead.org, David Woodhouse , linux-kernel@vger.kernel.org Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2012-03-09 at 10:49 -0800, Joe Perches wrote: > On Fri, 2012-03-09 at 13:53 +0200, Artem Bityutskiy wrote: > > OK, pushed these ones, although I think that mechanical D1->jffs2_dbg() > > conversion is not very useful and to make your patch-set worth the > > trouble you should do few more clean-up steps, like I suggested. > > Do you want me to remove the D2/jffs2_dbg(2, ...) instances > or just eliminate the first arg to jffs2_dbg and keep the > current jffs2_dbg(2,...) instances? Just remove. There were few other suggestions as well :-) -- Best Regards, Artem Bityutskiy