From: Artem Bityutskiy <dedekind1@gmail.com>
To: h-fache@ti.com
Cc: joern@lazybastard.org, joern@logfs.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: phram: dot not crash when built-in and passing boot param
Date: Tue, 13 Mar 2012 15:23:55 +0200 [thread overview]
Message-ID: <1331645035.3595.60.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1331632351-32610-1-git-send-email-h-fache@ti.com>
[-- Attachment #1: Type: text/plain, Size: 964 bytes --]
On Tue, 2012-03-13 at 10:52 +0100, h-fache@ti.com wrote:
> +/* This shall contain the module parameter if any. It is of the form:
> + * phram=<device>,<address>,<size> for module case
> + * phram.phram=<device>,<address>,<size> for built-in case
> + We leave 64 bytes for the device name, 12 for the address and 12 for the
> + size.
> + Example: phram.phram=rootfs,0xa0000000,512Mi
> +*/
Sorry for this, but please, while you are on it, still, turn all your
comments into the standard Linux-style comments. This is not that
important, but just cleaner.
> +static __initdata char phram_paramline[64+12+12];
Despite that you told that there are not section mismatches, which I
doubted and thus decided to check, I see that this patch _does_ cause a
section mismatch:
+WARNING: modpost: Found 1 section mismatch(es).
+To see full details build your kernel with:
Could you please fix this?
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-13 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 9:52 [PATCH] mtd: phram: dot not crash when built-in and passing boot param h-fache
2012-03-13 13:06 ` Artem Bityutskiy
2012-03-13 13:23 ` Artem Bityutskiy [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-13 15:07 h-fache
2012-03-14 11:55 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331645035.3595.60.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=h-fache@ti.com \
--cc=joern@lazybastard.org \
--cc=joern@logfs.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox