From: Artem Bityutskiy <dedekind1@gmail.com>
To: Xi Wang <xi.wang@gmail.com>
Cc: linux-mtd@lists.infradead.org, David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] jffs2: refactor csize in jffs2_do_read_inode_internal()
Date: Sat, 21 Apr 2012 17:12:58 +0300 [thread overview]
Message-ID: <1335017578.28642.6.camel@brekeke> (raw)
In-Reply-To: <1334011379-24445-1-git-send-email-xi.wang@gmail.com>
On Mon, 2012-04-09 at 18:42 -0400, Xi Wang wrote:
> Replace the verbose `je32_to_cpu(latest_node->csize)' with a shorter
> variable `csize'.
>
> Also check for a bogus `csize' value 0xffffffff, which would turn the
> subsequent kmalloc(cisze + 1, ...) into kmalloc(0, ...).
>
> Signed-off-by: Xi Wang <xi.wang@gmail.com>
Looks good. I wonder, does it fix a real-life issue or you spotted this
place while reviewing/fixing warnings/other janitor type of work?
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2012-04-21 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 22:42 [PATCH] jffs2: refactor csize in jffs2_do_read_inode_internal() Xi Wang
2012-04-21 14:12 ` Artem Bityutskiy [this message]
2012-04-21 16:44 ` Xi Wang
2012-04-22 11:57 ` Artem Bityutskiy
2012-04-23 5:43 ` Xi Wang
2012-04-23 6:00 ` Artem Bityutskiy
2012-04-23 6:58 ` Xi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335017578.28642.6.camel@brekeke \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox