From: Brian Norris <computersforpeace@gmail.com>
To: <linux-mtd@lists.infradead.org>
Cc: Viresh Kumar <viresh.kumar@st.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Vipin Kumar <vipin.kumar@st.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Florian Fainelli <ffainelli@freebox.fr>,
Jamie Iles <jamie@jamieiles.com>,
prabhakar@freescale.com, Mike Dunn <mikedunn@newsguy.com>,
Bastian Hecht <hechtb@gmail.com>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
Kevin Cernekee <cernekee@gmail.com>, Lei Wen <leiwen@marvell.com>,
Axel Lin <axel.lin@gmail.com>, Li Yang <leoli@freescale.com>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
Armando Visconti <armando.visconti@st.com>,
Thomas Gleixner <tglx@linutronix.de>,
Scott Branden <sbranden@broadcom.com>,
Artem Bityutskiy <dedekind1@gmail.com>,
Wolfram Sang <w.sang@pengutronix.de>,
Matthieu CASTET <matthieu.castet@parrot.com>,
Huang Shijie <b32955@freescale.com>,
Shmulik Ladkani <shmulik.ladkani@gmail.com>,
Jiandong Zheng <jdzheng@broadcom.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: [PATCH v2 0/2] mtd: nand: rework nand_ecc_ctrl interface for OOB
Date: Mon, 23 Apr 2012 13:14:27 -0700 [thread overview]
Message-ID: <1335212069-7450-1-git-send-email-computersforpeace@gmail.com> (raw)
Hello again,
This is v2 of my patches to change the nand_chip and nand_ecc_ctrl interfaces
so that the nand_ecc_ctrl functions have information about whether the higher
layers actually need OOB data to be read/written from/to the NAND device. Per
some suggestions I have received, I have settled on using a boolean 'use_oob'
argument that tells the callee function whether the calling function is using
chip->oob_poi for OOB data.
Please refer to previous communications for other details.
Similar notes from last time:
I could not compile all the affected drivers, since some required ARCH-specific
builds that I am not familiar with.
Artem: can you perform your regular compile tests? I compile-tested as many as
I could.
Others: if you care about your driver, please compile test and review to be
sure I'm doing things safely for you. Because most in-kernel drivers seem to be
perfecly happy using nand_chip.oob_poi for OOB data unconditionally, I have not
struggled to port most of them to take advantage of this full change. However,
some developers have noted that certain drivers could benefit from utilizing
this 'use_oob' parameter. Fell free to write/submit/review any code on top of
these patches, assuming they are eventually accepted.
Thanks for reviewing!
Brian
Brian Norris (2):
mtd: nand: add 'use_oob' argument to NAND {read,write}_page
interfaces
mtd: nand: nand_base - pass proper 'use_oob' parameter
drivers/mtd/nand/atmel_nand.c | 3 +-
drivers/mtd/nand/bcm_umi_bch.c | 10 +++--
drivers/mtd/nand/bcm_umi_nand.c | 2 +-
drivers/mtd/nand/bf5xx_nand.c | 4 +-
drivers/mtd/nand/cafe_nand.c | 13 ++++---
drivers/mtd/nand/denali.c | 8 ++--
drivers/mtd/nand/docg4.c | 12 +++---
drivers/mtd/nand/fsl_elbc_nand.c | 11 ++----
drivers/mtd/nand/fsl_ifc_nand.c | 10 ++---
drivers/mtd/nand/fsmc_nand.c | 3 +-
drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 6 ++--
drivers/mtd/nand/nand_base.c | 58 ++++++++++++++++++++-----------
drivers/mtd/nand/pxa3xx_nand.c | 4 +-
drivers/mtd/nand/sh_flctl.c | 4 +-
include/linux/mtd/nand.h | 11 +++---
15 files changed, 89 insertions(+), 70 deletions(-)
--
1.7.5.4.2.g519b1
next reply other threads:[~2012-04-23 20:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 20:14 Brian Norris [this message]
2012-04-23 20:14 ` [PATCH v2 1/2] mtd: nand: add 'use_oob' argument to NAND {read, write}_page interfaces Brian Norris
2012-04-24 12:28 ` [PATCH v2 1/2] mtd: nand: add 'use_oob' argument to NAND {read,write}_page interfaces Shmulik Ladkani
2012-04-25 3:42 ` Brian Norris
2012-04-25 7:25 ` Shmulik Ladkani
2012-04-23 20:14 ` [PATCH v2 2/2] mtd: nand: nand_base - pass proper 'use_oob' parameter Brian Norris
2012-04-25 15:38 ` [PATCH v2 0/2] mtd: nand: rework nand_ecc_ctrl interface for OOB Artem Bityutskiy
2012-04-25 18:22 ` Brian Norris
2012-04-25 15:45 ` Artem Bityutskiy
2012-04-25 16:07 ` Bastian Hecht
2012-04-25 16:25 ` Guennadi Liakhovetski
2012-05-01 19:02 ` Jiandong Zheng
2012-05-02 1:02 ` Brian Norris
2012-05-02 16:38 ` JD (Jiandong) Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335212069-7450-1-git-send-email-computersforpeace@gmail.com \
--to=computersforpeace@gmail.com \
--cc=armando.visconti@st.com \
--cc=axel.lin@gmail.com \
--cc=b32955@freescale.com \
--cc=cernekee@gmail.com \
--cc=dbaryshkov@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ffainelli@freebox.fr \
--cc=hechtb@gmail.com \
--cc=jamie@jamieiles.com \
--cc=jdzheng@broadcom.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=leiwen@marvell.com \
--cc=leoli@freescale.com \
--cc=linux-mtd@lists.infradead.org \
--cc=matthieu.castet@parrot.com \
--cc=mikedunn@newsguy.com \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=prabhakar@freescale.com \
--cc=sbranden@broadcom.com \
--cc=shmulik.ladkani@gmail.com \
--cc=tglx@linutronix.de \
--cc=vipin.kumar@st.com \
--cc=viresh.kumar@st.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox