public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: <linux-mtd@lists.infradead.org>
Cc: Viresh Kumar <viresh.kumar@st.com>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Vipin Kumar <vipin.kumar@st.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Florian Fainelli <ffainelli@freebox.fr>,
	Jamie Iles <jamie@jamieiles.com>,
	prabhakar@freescale.com, Mike Dunn <mikedunn@newsguy.com>,
	Bastian Hecht <hechtb@gmail.com>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	Kevin Cernekee <cernekee@gmail.com>, Lei Wen <leiwen@marvell.com>,
	Axel Lin <axel.lin@gmail.com>, Li Yang <leoli@freescale.com>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
	Armando Visconti <armando.visconti@st.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Scott Branden <sbranden@broadcom.com>,
	Artem Bityutskiy <dedekind1@gmail.com>,
	Wolfram Sang <w.sang@pengutronix.de>,
	Matthieu CASTET <matthieu.castet@parrot.com>,
	Huang Shijie <b32955@freescale.com>,
	Shmulik Ladkani <shmulik.ladkani@gmail.com>,
	Jiandong Zheng <jdzheng@broadcom.com>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: [PATCH v2 2/2] mtd: nand: nand_base - pass proper 'use_oob' parameter
Date: Mon, 23 Apr 2012 13:14:29 -0700	[thread overview]
Message-ID: <1335212069-7450-3-git-send-email-computersforpeace@gmail.com> (raw)
In-Reply-To: <1335212069-7450-1-git-send-email-computersforpeace@gmail.com>

We now have an interface for notifying the nand_ecc_ctrl functions when OOB
data must be returned to the upper layers and when it is simply needed for
internal calculations. This patch fills in the 'use_oob' parameter properly
from nand_do_{read,write}_ops. When utilized properly in the lower layers, this
parameter can improve performance for NAND HW that can simply avoid
transferring the OOB data.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
 drivers/mtd/nand/nand_base.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index c4989b5..089923c 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -1477,6 +1477,7 @@ static int nand_do_read_ops(struct mtd_info *mtd, loff_t from,
 		mtd->oobavail : mtd->oobsize;
 
 	uint8_t *bufpoi, *oob, *buf;
+	bool use_oob;
 
 	stats = mtd->ecc_stats;
 
@@ -1490,6 +1491,7 @@ static int nand_do_read_ops(struct mtd_info *mtd, loff_t from,
 
 	buf = ops->datbuf;
 	oob = ops->oobbuf;
+	use_oob = oob ? true : false;
 
 	while (1) {
 		bytes = min(mtd->writesize - col, readlen);
@@ -1507,13 +1509,13 @@ static int nand_do_read_ops(struct mtd_info *mtd, loff_t from,
 			/* Now read the page into the buffer */
 			if (unlikely(ops->mode == MTD_OPS_RAW))
 				ret = chip->ecc.read_page_raw(mtd, chip, bufpoi,
-							      true, page);
+							      use_oob, page);
 			else if (!aligned && NAND_SUBPAGE_READ(chip) && !oob)
 				ret = chip->ecc.read_subpage(mtd, chip,
 							col, bytes, bufpoi);
 			else
 				ret = chip->ecc.read_page(mtd, chip, bufpoi,
-							  true, page);
+							  use_oob, page);
 			if (ret < 0) {
 				if (!aligned)
 					/* Invalidate page cache */
@@ -1536,7 +1538,6 @@ static int nand_do_read_ops(struct mtd_info *mtd, loff_t from,
 			buf += bytes;
 
 			if (unlikely(oob)) {
-
 				int toread = min(oobreadlen, max_oobsize);
 
 				if (toread) {
@@ -2216,6 +2217,7 @@ static int nand_do_write_ops(struct mtd_info *mtd, loff_t to,
 	uint8_t *oob = ops->oobbuf;
 	uint8_t *buf = ops->datbuf;
 	int ret, subpage;
+	bool use_oob = oob ? true : false;
 
 	ops->retlen = 0;
 	if (!writelen)
@@ -2278,7 +2280,7 @@ static int nand_do_write_ops(struct mtd_info *mtd, loff_t to,
 			memset(chip->oob_poi, 0xff, mtd->oobsize);
 		}
 
-		ret = chip->write_page(mtd, chip, wbuf, true, page, cached,
+		ret = chip->write_page(mtd, chip, wbuf, use_oob, page, cached,
 				       (ops->mode == MTD_OPS_RAW));
 		if (ret)
 			break;
-- 
1.7.5.4.2.g519b1

  parent reply	other threads:[~2012-04-23 20:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-23 20:14 [PATCH v2 0/2] mtd: nand: rework nand_ecc_ctrl interface for OOB Brian Norris
2012-04-23 20:14 ` [PATCH v2 1/2] mtd: nand: add 'use_oob' argument to NAND {read, write}_page interfaces Brian Norris
2012-04-24 12:28   ` [PATCH v2 1/2] mtd: nand: add 'use_oob' argument to NAND {read,write}_page interfaces Shmulik Ladkani
2012-04-25  3:42     ` Brian Norris
2012-04-25  7:25       ` Shmulik Ladkani
2012-04-23 20:14 ` Brian Norris [this message]
2012-04-25 15:38 ` [PATCH v2 0/2] mtd: nand: rework nand_ecc_ctrl interface for OOB Artem Bityutskiy
2012-04-25 18:22   ` Brian Norris
2012-04-25 15:45 ` Artem Bityutskiy
2012-04-25 16:07   ` Bastian Hecht
2012-04-25 16:25     ` Guennadi Liakhovetski
2012-05-01 19:02 ` Jiandong Zheng
2012-05-02  1:02   ` Brian Norris
2012-05-02 16:38     ` JD (Jiandong) Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1335212069-7450-3-git-send-email-computersforpeace@gmail.com \
    --to=computersforpeace@gmail.com \
    --cc=armando.visconti@st.com \
    --cc=axel.lin@gmail.com \
    --cc=b32955@freescale.com \
    --cc=cernekee@gmail.com \
    --cc=dbaryshkov@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=ffainelli@freebox.fr \
    --cc=hechtb@gmail.com \
    --cc=jamie@jamieiles.com \
    --cc=jdzheng@broadcom.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=leiwen@marvell.com \
    --cc=leoli@freescale.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=matthieu.castet@parrot.com \
    --cc=mikedunn@newsguy.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=prabhakar@freescale.com \
    --cc=sbranden@broadcom.com \
    --cc=shmulik.ladkani@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=vipin.kumar@st.com \
    --cc=viresh.kumar@st.com \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox