From: Artem Bityutskiy <dedekind1@gmail.com>
To: Mark <xiaoming1981.zhang@gmail.com>
Cc: linux-mtd <linux-mtd@lists.infradead.org>, zxm927@163.com
Subject: Re: [PATCH] ubi: Do "dump_stack()" in case of the ubi_io_read()/ubi_io_write()/do_sync_erase() has an error
Date: Tue, 24 Apr 2012 06:50:42 +0300 [thread overview]
Message-ID: <1335239442.14183.3.camel@brekeke> (raw)
In-Reply-To: <4F954BAD.2010606@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 868 bytes --]
On Mon, 2012-04-23 at 20:31 +0800, Mark wrote:
> ubi: Do "dump_stack()" to always have the dump in case of the
> ubi_io_read()/ubi_io_write()/do_sync_erase() has an error.
>
> Signed-off-by: Mark Zhang <mark.zhang@motorola.com>
Mark, sorry, but this patch is not applicable because it is
1) line-wrapped
2) against some old UBI version.
To check what I mean - save it from the mailing list as mbox and try to
apply it using git am to the upstream kernel.
Also, keep in mind that the subject line should be short and only give
idea what the patch does without details. In this case I'd prefer "UBI:
dump the stack in case of I/O errors".
BTW, I suggest you to use newer kernel or pull one of the ubifs
back-port trees which also contains all the UBI back-ports.
Anyway, I'll do this change myself now.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-04-24 3:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 2:37 [PATCH] ubi: Do "dump_stack()" in case of the ubi_io_read()/ubi_io_write()/do_sync_erase() has an error Xiaoming Zhang
2012-04-23 5:59 ` Artem Bityutskiy
2012-04-23 12:31 ` Mark
2012-04-24 3:50 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335239442.14183.3.camel@brekeke \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=xiaoming1981.zhang@gmail.com \
--cc=zxm927@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox