From: Artem Bityutskiy <dedekind1@gmail.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: MIPS Mailing List <linux-mips@linux-mips.org>,
MTD Maling List <linux-mtd@lists.infradead.org>
Subject: [PATCH 2/2] MIPS: bcm63xx: kbuild: remove -Werror
Date: Fri, 27 Apr 2012 16:48:30 +0300 [thread overview]
Message-ID: <1335534510-12573-2-git-send-email-dedekind1@gmail.com> (raw)
In-Reply-To: <1335534510-12573-1-git-send-email-dedekind1@gmail.com>
From: Artem Bityutskiy <Artem.Bityutskiy@linux.intel.com>
I cannot build bcm963xx with the standard Kbuild W=1 switch:
arch/mips/bcm63xx/boards/board_bcm963xx.c: At top level:
arch/mips/bcm63xx/boards/board_bcm963xx.c:647:5: error: no previous prototype for 'bcm63xx_get_fallback_sprom' [-Werror=missing-prototypes]
cc1: all warnings being treated as errors
This patch removes the gcc switch to make W=1 work. Mips is the only
architecture I know which does not build with W=1 and this upsets my aiaiai
scripts. And in general, you never know which warnings newer versions of gcc
will start emiting so having -Werror by default is not the best idea.
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
arch/mips/bcm63xx/boards/Makefile | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/mips/bcm63xx/boards/Makefile b/arch/mips/bcm63xx/boards/Makefile
index 9f64fb4..af07c1a 100644
--- a/arch/mips/bcm63xx/boards/Makefile
+++ b/arch/mips/bcm63xx/boards/Makefile
@@ -1,3 +1 @@
obj-$(CONFIG_BOARD_BCM963XX) += board_bcm963xx.o
-
-ccflags-y := -Werror
--
1.7.9.1
next prev parent reply other threads:[~2012-04-27 13:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 13:48 [PATCH 1/2] MIPS: Kbuild: remove -Werror Artem Bityutskiy
2012-04-27 13:48 ` Artem Bityutskiy [this message]
2012-05-06 7:06 ` [PATCH 2/2] MIPS: bcm63xx: kbuild: " Maciej W. Rozycki
2012-05-06 7:36 ` Artem Bityutskiy
2012-05-21 18:15 ` Ralf Baechle
2012-04-27 17:03 ` [PATCH 1/2] MIPS: Kbuild: " David Daney
2012-05-06 7:04 ` Maciej W. Rozycki
2012-05-06 7:34 ` Artem Bityutskiy
2012-05-06 8:32 ` Maciej W. Rozycki
2012-05-06 8:37 ` Artem Bityutskiy
2012-05-06 9:14 ` Maciej W. Rozycki
2012-05-13 12:08 ` Jonas Gorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335534510-12573-2-git-send-email-dedekind1@gmail.com \
--to=dedekind1@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).