linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: <linux-mtd@lists.infradead.org>
Cc: Lei Wen <leiwen@marvell.com>, Li Yang <leoli@freescale.com>,
	Mike Dunn <mikedunn@newsguy.com>,
	Prabhakar Kushwaha <prabhakar@freescale.com>,
	Artem Bityutskiy <dedekind1@gmail.com>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
	Kevin Cernekee <cernekee@gmail.com>,
	Wolfram Sang <w.sang@pengutronix.de>,
	Matthieu CASTET <matthieu.castet@parrot.com>,
	Huang Shijie <b32955@freescale.com>,
	Shmulik Ladkani <shmulik.ladkani@gmail.com>,
	Florian Fainelli <ffainelli@freebox.fr>,
	Scott Wood <scottwood@freescale.com>,
	Jamie Iles <jamie@jamieiles.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Axel Lin <axel.lin@gmail.com>,
	Bastian Hecht <hechtb@googlemail.com>
Subject: [PATCH v3 00/10] mtd: nand: rework nand_ecc_ctrl interface for OOB
Date: Fri, 27 Apr 2012 18:29:44 -0700	[thread overview]
Message-ID: <1335576594-25267-1-git-send-email-computersforpeace@gmail.com> (raw)

Hello again,

This is the third (final?) version of my patches to change the nand_chip and
nand_ecc_ctrl interfaces so that the nand_ecc_ctrl functions have information
about whether the higher layers actually need OOB data to be read/written
from/to the NAND device.

Changes for v3:

 This version implements the boolean parameter 'int oob_required', where a
 non-zero value indicates the driver must read/write OOB data to chip->oob_poi.
 A zero value indicates apathy from the upper layer.

 Patches 3-10 are new, where I try to utilize the 'oob_required' parameter for
 a number of different drivers. Not all were easy (or even possible), since
 software-based ECC obviously requires the OOB data in a buffer even when the
 upper layer doesn't need it. Similarly, some "hardware ECC" seems to work off
 of an in-memory buffer.

Please refer to previous communications for other info.

I could not compile all the affected drivers, since some required ARCH-specific
builds that I am not familiar with.

Developers: if you care about your driver, please compile test and review to be
sure I'm doing things safely for you.

Note to the maintainers: please do NOT accept any of the patches 3-10 without
an explicit ACK from someone who knows the driver. I think they're simple, but
I am not certain. And it is totally safe to ignore one or several of those
patches independently.

Thanks for reviewing!

Brian

Brian Norris (10):
  mtd: nand: add 'oob_required' argument to NAND {read,write}_page
    interfaces
  mtd: nand: pass proper 'oob_required' parameter
  mtd: Blackfin NFC: utilize oob_required parameter
  mtd: cafe_nand: utilize oob_required parameter
  mtd: denali: utilize oob_required parameter
  mtd: eLBD NAND: utilize oob_required parameter
  mtd: IFC NAND: utilize oob_required parameter
  mtd: gpmi-nand: utilize oob_requested parameter
  mtd: nand: utilize oob_required parameter
  mtd: pxa3xx_nand: utilize oob_required parameter

 drivers/mtd/nand/atmel_nand.c          |    5 +-
 drivers/mtd/nand/bcm_umi_bch.c         |   10 +++--
 drivers/mtd/nand/bcm_umi_nand.c        |    2 +-
 drivers/mtd/nand/bf5xx_nand.c          |   10 +++--
 drivers/mtd/nand/cafe_nand.c           |   16 +++++---
 drivers/mtd/nand/denali.c              |   12 +++--
 drivers/mtd/nand/docg4.c               |   12 +++---
 drivers/mtd/nand/fsl_elbc_nand.c       |   17 ++++----
 drivers/mtd/nand/fsl_ifc_nand.c        |   16 ++++----
 drivers/mtd/nand/fsmc_nand.c           |    3 +-
 drivers/mtd/nand/gpmi-nand/gpmi-nand.c |   41 ++++++++++---------
 drivers/mtd/nand/nand_base.c           |   70 ++++++++++++++++++++------------
 drivers/mtd/nand/pxa3xx_nand.c         |   11 +++--
 drivers/mtd/nand/sh_flctl.c            |    4 +-
 include/linux/mtd/nand.h               |   11 +++--
 15 files changed, 138 insertions(+), 102 deletions(-)

-- 
1.7.5.4.2.g519b1

             reply	other threads:[~2012-04-28  1:31 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-28  1:29 Brian Norris [this message]
2012-04-28  1:29 ` [PATCH v3 01/10] mtd: nand: add 'oob_required' argument to NAND {read, write}_page interfaces Brian Norris
2012-04-29 11:36   ` [PATCH v3 01/10] mtd: nand: add 'oob_required' argument to NAND {read,write}_page interfaces Shmulik Ladkani
2012-04-29 13:25     ` Artem Bityutskiy
2012-04-30 19:16       ` Brian Norris
2012-04-30 19:21         ` Scott Wood
2012-04-28  1:29 ` [PATCH v3 02/10] mtd: nand: pass proper 'oob_required' parameter Brian Norris
2012-04-29 11:41   ` Shmulik Ladkani
2012-04-28  1:29 ` [PATCH v3 03/10] mtd: Blackfin NFC: utilize oob_required parameter Brian Norris
2012-04-28  1:29 ` [PATCH v3 04/10] mtd: cafe_nand: " Brian Norris
2012-04-28  1:29 ` [PATCH v3 05/10] mtd: denali: " Brian Norris
2012-04-28  1:29 ` [PATCH v3 06/10] mtd: eLBD NAND: " Brian Norris
2012-04-28  1:29 ` [PATCH v3 07/10] mtd: IFC " Brian Norris
2012-04-30 16:43   ` Scott Wood
2012-04-30 19:08     ` Brian Norris
2012-04-30 19:13       ` Scott Wood
2012-04-30 19:23         ` Brian Norris
2012-04-30 19:32           ` Scott Wood
2012-04-28  1:29 ` [PATCH v3 08/10] mtd: gpmi-nand: utilize oob_requested parameter Brian Norris
2012-04-28  2:32   ` Huang Shijie
2012-04-28  1:29 ` [PATCH v3 09/10] mtd: nand: utilize oob_required parameter Brian Norris
2012-04-29 12:47   ` Shmulik Ladkani
2012-04-30 19:59     ` Brian Norris
2012-04-30 20:12       ` Brian Norris
2012-04-30 20:21       ` Scott Wood
2012-04-30 21:49         ` Brian Norris
2012-05-01 12:12           ` Artem Bityutskiy
2012-05-01  8:29       ` Shmulik Ladkani
2012-04-28  1:29 ` [PATCH v3 10/10] mtd: pxa3xx_nand: " Brian Norris
2012-04-30  7:10 ` [PATCH v3 00/10] mtd: nand: rework nand_ecc_ctrl interface for OOB Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1335576594-25267-1-git-send-email-computersforpeace@gmail.com \
    --to=computersforpeace@gmail.com \
    --cc=axel.lin@gmail.com \
    --cc=b32955@freescale.com \
    --cc=cernekee@gmail.com \
    --cc=dbaryshkov@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=ffainelli@freebox.fr \
    --cc=hechtb@googlemail.com \
    --cc=jamie@jamieiles.com \
    --cc=leiwen@marvell.com \
    --cc=leoli@freescale.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=matthieu.castet@parrot.com \
    --cc=mikedunn@newsguy.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=prabhakar@freescale.com \
    --cc=scottwood@freescale.com \
    --cc=shmulik.ladkani@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).