From: Artem Bityutskiy <dedekind1@gmail.com>
To: Jean-Christophe DUBOIS <jcd@tribudubois.net>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] [JFFS2] load_xattr_datum need to return a positive number in case of unrecoverable error
Date: Tue, 01 May 2012 15:15:54 +0300 [thread overview]
Message-ID: <1335874554.2095.7.camel@koala> (raw)
In-Reply-To: <4F9EFBF5.6080908@tribudubois.net>
[-- Attachment #1: Type: text/plain, Size: 884 bytes --]
On Mon, 2012-04-30 at 22:54 +0200, Jean-Christophe DUBOIS wrote:
> On 29/04/2012 17:44, Artem Bityutskiy wrote:
> > On Thu, 2012-04-26 at 23:09 +0200, Jean-Christophe DUBOIS wrote:
> >> Is this convincing enough?
> > Sure, thanks.
> >
> >> You might think that the attibute corruption I am showing here is very
> >> artificial but I can assure you that it does happen in the wild when you
> >> get a power cut on your equipment while the GC was moving an attribute
> >> node for example.
> > This issue is for sure worth fixing.
> So, will you accept this patch?
No, I meant that I agree that there is an issue, but I think that it
should be solved for all node types the same way. So I suggest to look
at what happens when data nodes are corrupted, how JFFS2 picks the older
node (if it does) and do it similarly for xattrs.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-01 12:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 20:54 [PATCH] [JFFS2] load_xattr_datum need to return a positive number in case of unrecoverable error Jean-Christophe DUBOIS
2012-04-22 13:08 ` Artem Bityutskiy
2012-04-22 13:16 ` Artem Bityutskiy
2012-04-22 17:35 ` Jean-Christophe DUBOIS
2012-04-25 13:59 ` Artem Bityutskiy
2012-04-26 21:09 ` Jean-Christophe DUBOIS
2012-04-29 15:44 ` Artem Bityutskiy
2012-04-30 20:54 ` Jean-Christophe DUBOIS
2012-05-01 12:15 ` Artem Bityutskiy [this message]
2012-05-01 14:31 ` Jean-Christophe DUBOIS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335874554.2095.7.camel@koala \
--to=dedekind1@gmail.com \
--cc=jcd@tribudubois.net \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox