linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Bastian Hecht <hechtb@googlemail.com>
To: linux-mtd@lists.infradead.org, linux-sh@vger.kernel.org
Cc: Brian Norris <computersforpeace@gmail.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	Laurent Pichart <laurent.pinchart@ideasonboard.com>,
	Artem Bityutskiy <dedekind1@gmail.com>
Subject: [PATCH v3 06/10] mtd: sh_flctl: Simplify the hardware ecc page read/write
Date: Wed,  2 May 2012 11:41:46 +0200	[thread overview]
Message-ID: <1335951710-9390-7-git-send-email-hechtb@gmail.com> (raw)
In-Reply-To: <1335951710-9390-1-git-send-email-hechtb@gmail.com>

As the equation mtd->writesize == eccsteps * eccsize holds, we can
simplify the code. The second loop of the 1st hunk is never entered,
so we delete it.

Signed-off-by: Bastian Hecht <hechtb@gmail.com>
---
 drivers/mtd/nand/sh_flctl.c |   25 ++-----------------------
 1 files changed, 2 insertions(+), 23 deletions(-)

diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c
index 4ea3e20..b0389c5 100644
--- a/drivers/mtd/nand/sh_flctl.c
+++ b/drivers/mtd/nand/sh_flctl.c
@@ -346,35 +346,14 @@ static void set_cmd_regs(struct mtd_info *mtd, uint32_t cmd, uint32_t flcmcdr_va
 static int flctl_read_page_hwecc(struct mtd_info *mtd, struct nand_chip *chip,
 				uint8_t *buf, int page)
 {
-	int i, eccsize = chip->ecc.size;
-	int eccbytes = chip->ecc.bytes;
-	int eccsteps = chip->ecc.steps;
-	uint8_t *p = buf;
-	struct sh_flctl *flctl = mtd_to_flctl(mtd);
-
-	for (i = 0; eccsteps; eccsteps--, i += eccbytes, p += eccsize)
-		chip->read_buf(mtd, p, eccsize);
-
-	for (i = 0; eccsteps; eccsteps--, i += eccbytes, p += eccsize) {
-		if (flctl->hwecc_cant_correct[i])
-			mtd->ecc_stats.failed++;
-		else
-			mtd->ecc_stats.corrected += 0; /* FIXME */
-	}
-
+	chip->read_buf(mtd, buf, mtd->writesize);
 	return 0;
 }
 
 static void flctl_write_page_hwecc(struct mtd_info *mtd, struct nand_chip *chip,
 				   const uint8_t *buf)
 {
-	int i, eccsize = chip->ecc.size;
-	int eccbytes = chip->ecc.bytes;
-	int eccsteps = chip->ecc.steps;
-	const uint8_t *p = buf;
-
-	for (i = 0; eccsteps; eccsteps--, i += eccbytes, p += eccsize)
-		chip->write_buf(mtd, p, eccsize);
+	chip->write_buf(mtd, buf, mtd->writesize);
 }
 
 static void execmd_read_page_sector(struct mtd_info *mtd, int page_addr)
-- 
1.7.5.4

  parent reply	other threads:[~2012-05-02  9:42 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-02  9:41 [PATCH v3 0/10] sh_flctl hardware ECC mode cleanup Bastian Hecht
2012-05-02  9:41 ` [PATCH v3 01/10] mtd: sh_flctl: Add missing iounmap() Bastian Hecht
2012-05-02  9:41 ` [PATCH v3 02/10] ARM: sh-mobile: mackerel: Add error IRQ resource Bastian Hecht
2012-05-02 20:49   ` Rafael J. Wysocki
2012-05-02 21:03     ` Magnus Damm
2012-05-03  6:00     ` Artem Bityutskiy
2012-05-03  6:01       ` Artem Bityutskiy
2012-05-03  9:29         ` Bastian Hecht
2012-05-03 10:05           ` Artem Bityutskiy
2012-05-03 13:31             ` Rafael J. Wysocki
2012-05-02  9:41 ` [PATCH v3 03/10] mtd: sh_flctl: Add support for error IRQ Bastian Hecht
2012-05-02  9:41 ` [PATCH v3 04/10] mtd: sh_flctl: Use different OOB layout Bastian Hecht
2012-05-02  9:41 ` [PATCH v3 05/10] mtd: sh_flctl: Fix hardware ECC behaviour Bastian Hecht
2012-05-02  9:41 ` Bastian Hecht [this message]
2012-05-02  9:41 ` [PATCH v3 07/10] mtd: sh_flctl: Group sector accesses into a single transfer Bastian Hecht
2012-05-02  9:41 ` [PATCH v3 08/10] mtd: sh_flctl: Restructure the hardware ECC handling Bastian Hecht
2012-05-02  9:41 ` [PATCH v3 09/10] mtd: sh_flctl: Use user oob data in hardware ECC mode Bastian Hecht
2012-05-02  9:41 ` [PATCH v3 10/10] ARM: sh-mobile: mackerel: Use hardware error correction Bastian Hecht
2012-05-02 10:38 ` [PATCH v3 0/10] sh_flctl hardware ECC mode cleanup Artem Bityutskiy
2012-05-02 11:51   ` Bastian Hecht
2012-05-02 12:02     ` Artem Bityutskiy
2012-05-02 13:41       ` Bastian Hecht
2012-05-02 13:55         ` Artem Bityutskiy
2012-05-02 14:00           ` Bastian Hecht
2012-05-02 14:08             ` Artem Bityutskiy
2012-05-02 14:40               ` Bastian Hecht
2012-05-02 14:46                 ` Bastian Hecht
2012-05-02 14:51                 ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1335951710-9390-7-git-send-email-hechtb@gmail.com \
    --to=hechtb@googlemail.com \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).