From: Artem Bityutskiy <dedekind1@gmail.com>
To: Mike Dunn <mikedunn@newsguy.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: use ecc_strength to determine whether to perform bitflip_threshold test
Date: Wed, 02 May 2012 15:13:27 +0300 [thread overview]
Message-ID: <1335960807.10293.51.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1335902181-18110-1-git-send-email-mikedunn@newsguy.com>
[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]
On Tue, 2012-05-01 at 12:56 -0700, Mike Dunn wrote:
> This is a minor change to the recent EUCLEAN patch set that I think makes it
> more correct. Currently, the test in mtd_read() that determines whether or not
> to return -EUCLEAN is skipped if bitflip_threshold == 0. This logic was added
> (without much thought) to fix a bug in an earlier version of the patch set that
> would have caused devices lacking ecc to always return -EUCLEAN [1].
>
> This patch replaces bitflip_threshold with ecc_strength as the value used to
> determine whether the device has ecc capability. I think this is more correct
> because bitflip_threshold can be changed via sysfs. Currently, if the user sets
> it to zero, -EUCLEAN is never returned. This is also what happens if the user
> sets it to a value exceeding ecc_strength. With this patch, if the user sets it
> to zero, -EUCLEAN will always be returned (provided ecc_strength > 0), which
> makes more sense, and may even be useful occasionally.
>
> [1] http://lists.infradead.org/pipermail/linux-mtd/2012-March/040468.html
>
> Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
Folded this patch into:
mtd: driver _read() returns max_bitflips; mtd_read() returns -EUCLEAN
and pushed to l2-mtd.git, thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-05-02 12:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 19:56 [PATCH] mtd: use ecc_strength to determine whether to perform bitflip_threshold test Mike Dunn
2012-05-02 1:33 ` Brian Norris
2012-05-02 12:13 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335960807.10293.51.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=mikedunn@newsguy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).