From: Artem Bityutskiy <dedekind1@gmail.com>
To: Huang Shijie <b32955@freescale.com>
Cc: shawn.guo@linaro.org, linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] mtd: gpmi: add device tree support to gpmi-nand
Date: Fri, 04 May 2012 13:37:39 +0300 [thread overview]
Message-ID: <1336127859.4275.14.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <4FA3AEDF.8010009@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 3165 bytes --]
On Fri, 2012-05-04 at 18:26 +0800, Huang Shijie wrote:
> 于 2012年05月04日 17:41, Artem Bityutskiy 写道:
> > On Fri, 2012-05-04 at 11:13 +0800, Huang Shijie wrote:
> >> This patch just adds the DT support to gpmi-nand.
> >>
> >> Signed-off-by: Huang Shijie<b32955@freescale.com>
> >> ---
> >> Please select the CONFIG_USE_OF before you do the compiler-test.
> >> thanks.
> > It should compile without CONFIG_USE_OF also just fine. Currently it
> > does not.
> >
> why not select CONFIG_USE_OF as the gpmi-nand is converted to a DT driver.
Yes, it can be done as well. My point is that you should not break
compilation. These 2 patches do not compile with for me - aiaiai
reports:
--------------------------------------------------------------------------------
Failed to build the following commit for configuration "l2_mxs_defconfig" (architecture arm)":
d791f1c mtd: gpmi: add gpmi support for mx6q
drivers/mtd/nand/gpmi-nand/gpmi-lib.c:437:36: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
drivers/mtd/nand/gpmi-nand/gpmi-lib.c:579:35: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
In file included from include/linux/kernel.h:19:0,
from include/linux/clk.h:15,
from drivers/mtd/nand/gpmi-nand/gpmi-nand.c:21:
include/linux/bitops.h: In function 'hweight_long':
include/linux/bitops.h:66:26: warning: signed and unsigned type in conditional expression [-Wsign-compare]
In file included from include/linux/dma-mapping.h:73:0,
from drivers/mtd/nand/gpmi-nand/gpmi-nand.h:22,
from drivers/mtd/nand/gpmi-nand/gpmi-nand.c:28:
arch/arm/include/asm/dma-mapping.h: In function 'dma_mapping_error':
arch/arm/include/asm/dma-mapping.h:126:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
drivers/mtd/nand/gpmi-nand/gpmi-nand.c: In function 'release_bch_irq':
drivers/mtd/nand/gpmi-nand/gpmi-nand.c:382:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
drivers/mtd/nand/gpmi-nand/gpmi-nand.c: In function 'acquire_dma_channels':
drivers/mtd/nand/gpmi-nand/gpmi-nand.c:430:2: error: implicit declaration of function 'of_property_read_u32' [-Werror=implicit-function-declaration]
drivers/mtd/nand/gpmi-nand/gpmi-nand.c: In function 'mx23_check_transcription_stamp':
drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1186:9: warning: variable 'byte' set but not used [-Wunused-but-set-variable]
drivers/mtd/nand/gpmi-nand/gpmi-nand.c: In function 'mx23_write_transcription_stamp':
drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1247:15: warning: variable 'byte' set but not used [-Wunused-but-set-variable]
drivers/mtd/nand/gpmi-nand/gpmi-nand.c: At top level:
drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1448:6: warning: no previous prototype for 'gpmi_nfc_exit' [-Wmissing-prototypes]
cc1: some warnings being treated as errors
make[5]: *** [drivers/mtd/nand/gpmi-nand/gpmi-nand.o] Error 1
--------------------------------------------------------------------------------
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-05-04 10:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 3:13 [PATCH 1/2] mtd: gpmi: add device tree support to gpmi-nand Huang Shijie
2012-05-04 3:13 ` [PATCH 2/2] mtd: gpmi: add gpmi support for mx6q Huang Shijie
2012-05-04 3:36 ` [PATCH 1/2] mtd: gpmi: add device tree support to gpmi-nand Subodh Nijsure
2012-05-04 4:30 ` Huang Shijie
2012-05-04 9:41 ` Artem Bityutskiy
2012-05-04 10:26 ` Huang Shijie
2012-05-04 10:37 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336127859.4275.14.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=b32955@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).