From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: MIPS Mailing List <linux-mips@linux-mips.org>,
MTD Maling List <linux-mtd@lists.infradead.org>,
Ralf Baechle <ralf@linux-mips.org>,
David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH 1/2] MIPS: Kbuild: remove -Werror
Date: Sun, 06 May 2012 10:34:36 +0300 [thread overview]
Message-ID: <1336289676.1996.3.camel@koala> (raw)
In-Reply-To: <alpine.LFD.2.00.1205060754390.19691@eddie.linux-mips.org>
[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]
On Sun, 2012-05-06 at 08:04 +0100, Maciej W. Rozycki wrote:
> On Fri, 27 Apr 2012, David Daney wrote:
>
> > > MIPS build fails with the standard W=1 Kbuild switch with because of the
> > > -Werror gcc switch.
> > >
> > > This patch removes the gcc switch to make W=1 work. Mips is the only
> > > architecture I know which does not build with W=1 and this upsets my aiaiai
> > > scripts. And in general, you never know which warnings newer versions of gcc
> > > will start emiting so having -Werror by default is not the best idea.
> > >
> > > Signed-off-by: Artem Bityutskiy<artem.bityutskiy@linux.intel.com>
> >
> > I think the warning messages are enough, we don't need to break things.
>
> I disagree. People generally don't fix their broken code just because it
> triggers warnings. The cases where GCC is genuinely confused are the
> minority -- and even if so, chances are the human reader of that code will
> also be.
Aggressive opinion, nothing more. A patch which fixes the real issue a
better way would be way more respectful.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-06 7:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 13:48 [PATCH 1/2] MIPS: Kbuild: remove -Werror Artem Bityutskiy
2012-04-27 13:48 ` [PATCH 2/2] MIPS: bcm63xx: kbuild: " Artem Bityutskiy
2012-05-06 7:06 ` Maciej W. Rozycki
2012-05-06 7:36 ` Artem Bityutskiy
2012-05-21 18:15 ` Ralf Baechle
2012-04-27 17:03 ` [PATCH 1/2] MIPS: Kbuild: " David Daney
2012-05-06 7:04 ` Maciej W. Rozycki
2012-05-06 7:34 ` Artem Bityutskiy [this message]
2012-05-06 8:32 ` Maciej W. Rozycki
2012-05-06 8:37 ` Artem Bityutskiy
2012-05-06 9:14 ` Maciej W. Rozycki
2012-05-13 12:08 ` Jonas Gorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336289676.1996.3.camel@koala \
--to=dedekind1@gmail.com \
--cc=ddaney.cavm@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=macro@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).