linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Jean-Christophe DUBOIS <jcd@tribudubois.net>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] [JFFS2] check xattr data integrity during first GC scan.
Date: Thu, 10 May 2012 15:59:30 +0300	[thread overview]
Message-ID: <1336654770.2625.4.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1336480911-16707-1-git-send-email-jcd@tribudubois.net>

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

On Tue, 2012-05-08 at 14:41 +0200, Jean-Christophe DUBOIS wrote:
> This patch allows JFFS2 to distinguish between a recoverable
> and non recoverable errors and to act accordingly.
> 
> Furthermore, extended attribute integrity is now checked on
> first GC pass (at the same time as the file data integrity
> is checked).
> 
> Signed-off-by: Jean-Christophe DUBOIS <jcd@tribudubois.net>

Please, separate out the error code stuff and the checking stuff.
This should be at least 2 patches.

For the error code part - make sure you checked that the
JFFS2_XATTR_IS_CORRUPTED is never propagated to the user-space, if you
have to introduce it.

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

      reply	other threads:[~2012-05-10 12:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-08 12:41 [PATCH] [JFFS2] check xattr data integrity during first GC scan Jean-Christophe DUBOIS
2012-05-10 12:59 ` Artem Bityutskiy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336654770.2625.4.camel@sauron.fi.intel.com \
    --to=dedekind1@gmail.com \
    --cc=jcd@tribudubois.net \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).